1888702 - Minor cleanup in nsFlexContainerFrame and nsCSSFrameConstructor

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Minor cleanup while I'm investigating forced break in flex container in bug 1663079.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1888702 Part 1 - Remove unused #includes and forward declarations for flex container frame. r?#layout

Remove the forward declarations because we use mozilla:: prefix in the header.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1888702 Part 2 - Remove PrependPageBreakItem() and simplify AppendPageBreakItem(). r?#layout

The last caller of PrependPageBreakItem() is removed in
https://hg.mozilla.org/mozilla-central/rev/97613a0619b2

Since we only need to append page break items, we don't need
InsertPageBreakItem() and InsertPageBreakLocation enum. We can just implement
AppendPageBreakItem directly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ac33c5c516
Part 1 - Remove unused #includes and forward declarations for flex container frame. r=layout-reviewers,tnikkel
https://hg.mozilla.org/integration/autoland/rev/5abc3ab011c9
Part 2 - Remove PrependPageBreakItem() and simplify AppendPageBreakItem(). r=layout-reviewers,emilio

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/94ac33c5c516
https://hg.mozilla.org/mozilla-central/rev/5abc3ab011c9