188872 - Switching between type of HTMLInputElement incorrectly reset size from Int to pixel

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ruslan Ismailov]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030112

Well, it is easy: if <input> type was text or password, and new type would be
text or password, size should not change it's value form int to pixels. But it do.

To reproduce bug, run testcase and press on buttons. You could see, that each
odd click press size of input become default size, and each even click it become
size=12 again (no difference betwen order of buttons usage).

Source of this behaviour is in file
source/content/html/content/src/nsHTMLInputElement.cpp, on line 537:

526     // If the type of the input has changed we might need to change the type
527     // of the size attribute.
528     nsHTMLValue value;
529     if (NS_CONTENT_ATTR_HAS_VALUE ==
530         GetHTMLAttribute(nsHTMLAtoms::size, value)) {
531       if (value.GetUnit() == eHTMLUnit_Pixel &&
532           (mType == NS_FORM_INPUT_TEXT ||
533            mType == NS_FORM_INPUT_PASSWORD)) {
534         nsHTMLValue newValue(value.GetPixelValue(), eHTMLUnit_Integer);
535         SetHTMLAttribute(nsHTMLAtoms::size, newValue, PR_FALSE);
536       }
537       else if (value.GetUnit() == eHTMLUnit_Integer) {
538         nsHTMLValue newValue(value.GetIntValue(), eHTMLUnit_Pixel);
539         SetHTMLAttribute(nsHTMLAtoms::size, newValue, PR_FALSE);
540       }
541     }

As you see, if we switch from pixels, this code check that new value is integer,
but if we switching from ineger, if in line 537 don't check, that new type is
not password or int.

So I suggest to chahnge it to:

if (value.GetUnit() == eHTMLUnit_Integer &&
    mType != NS_FORM_INPUT_TEXT && mType != NS_FORM_INPUT_PASSWORD )

(according with
http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-type-INPUT
When the type attribute has the value "text" or "password", this attribute
specifies the maximum number of characters the user may enter. This number may
exceed the specified size, in which case the user agent should offer a scrolling
mechanism. The default value for this attribute is an unlimited number.)

Comment 1

[Ruslan Ismailov]

Attachment: Switching from text or password to text or password invalidate size

Comment 2

[Ruslan Ismailov]

Attachment: Proposed patch v1.0

Comment 3

[Boris Zbarsky [:bzbarsky]]

To peterv so he remembers to check this in

Comment 4

[Peter Van der Beken [:peterv]]

Checked in.