1888723 - [wpt-sync] Sync PR 45435 - [anchor] Sort candidate list before handing off to OOFLayoutPart.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45435 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45435
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[anchor] Sort candidate list before handing off to OOFLayoutPart.

The order of the candidates now is important, when it wasn't
previously. The order is only important when there is a child that
has an anchor within it, so to mitigate the performance, only sort
when that is true.

The order can get inconsistent for a variety of reasons, the testcase
is when we insert them in the incorrect order during simplified layout
(as we don't keep the OOFs in the same list as the child fragments).

Fixed: 330756838
Change-Id: I7e4e08d104c5a75e96b6250ba234183ca3ab458f

Reviewed-on: https://chromium-review.googlesource.com/5404921
WPT-Export-Revision: 10490af8886929602868f0b1540801a9188f6220

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=348e1cf64721aaf95cf973c829c19fbd8c1ef685

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/anchor-position-dynamic-005.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a5365a233a3
[wpt PR 45435] - [anchor] Sort candidate list before handing off to OOFLayoutPart., a=testonly
https://hg.mozilla.org/integration/autoland/rev/a10334295dd5
[wpt PR 45435] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a5365a233a3
https://hg.mozilla.org/mozilla-central/rev/a10334295dd5