1888861 - ZoomToFocusInput should wait for resize events in the parent process document rather than in hte content

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

This is a follow-up bug of bug 1649440.

In the content process we wait for at least one resize event before triggering nsIDOMWindowUtils.zoomToFocusedInput, but if the focused element is inside a cross-process iframe and the iframe size is quite small, say 50x50 px, then there's no resize event happens.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

This bug should block bug 1831649, though there's no significant impact on that bug since we end up calling nsIDOMWindoUtils.zoomToFocused after 500ms timed out.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1888861 - Wait for resize events in the parent process document for ZoomToFocusInput. r?#geckoview-reviewers,botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/962a7f1eca54
Wait for resize events in the parent process document for ZoomToFocusInput. r=geckoview-reviewers,m_kato

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_bug861217.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_bug861217.html | scrollWidth of #tableCell2 - got 106, expected 107

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Odd, the test fails on my local Android emulator with/without the change. Why the test passes on our CIs?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

The failure is unfortunate.

The failed test is supposed to be run on zoom level is 1. But unfortunately the test file doesn't specify any meta viewport tag, thus if it runs with "./mach mochitest dom/tests/mochitest/general/test_bug861217.html", it's rendered on < 1 zoom level, locally it was 0.8163265585899353.

Also in the same directly there are a couple of other tests triggering zoomToFocusInput, test_bug1170911.html for example, then it makes the zoom level is 1. Thus test_bug861217.html has been passing on our CIs.

Note that even with the change for this bug, I don't see the test failure locally even with "./mach mochitest dom/tests/mochitest/general/", so I'd guess the failure is very timing specific.

I am going to post a patch to make the test works with "./mach mochitest dom/tests/mochitest/general/test_bug861217.html".

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1888861 - Forcibly set the zoom level to 1 in test_bug861217.html. r?m_kato

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac3510c60f1e
Forcibly set the zoom level to 1 in test_bug861217.html. r=m_kato
https://hg.mozilla.org/integration/autoland/rev/54761c698e87
Wait for resize events in the parent process document for ZoomToFocusInput. r=geckoview-reviewers,m_kato

Comment 9

[pstanciu]

Backed out for causing (part of commit message)

• Backout link
• Push with failures
• Failure Log

Comment 10

[Hiroyuki Ikezoe (:hiro)]

The passed wpt is interactive-content.html, and the passed test case is <input type=color> one. With apz.zoom-to-focused-input.enabled:false the test case passes without the change for this bug, I'd set the pref for now.

I suppose this passed case is also racy on the interaction of zoomToFocusInput. I'd hope the case would be stable.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad62798030c
Forcibly set the zoom level to 1 in test_bug861217.html. r=m_kato
https://hg.mozilla.org/integration/autoland/rev/06a6a94fe1bd
Wait for resize events in the parent process document for ZoomToFocusInput. r=geckoview-reviewers,m_kato

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4ad62798030c
https://hg.mozilla.org/mozilla-central/rev/06a6a94fe1bd