1888878 - Remove arbitrary timeout from test_idle_maintenance_and_databases.js

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P2)

Description

[Jan Varga [:janv]]

We currently wait 10 seconds to let the maintenance start and finish, it would be better to have some kind of notification or promise which can be awaited.
See also https://phabricator.services.mozilla.com/D205830#7067693

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Add Maintenance::OnResults; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Add QuotaClient::DoMaintenance; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Bring back nsIIndexedDatabaseManager; r=#dom-storage

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Remove obsolete comment; r=#dom-storage

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Extract background actor creation into a separate function; r=#dom-storage

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Extract CreatePromise to PromiseUtils.h; r=#dom-storage

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Extract ResolveBoolResponseAndReturn to ErrorHandling.h; r=#dom-storage

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Add nsIIndexedDatabaseManager::DoMaintenance; r=#dom-storage

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Verify that idle-daily notification triggers maintenance; r=#dom-storage

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Update services.json; r=#dom-storage

This is needed for allowing Services.idm to be used in JS.

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1888878 - Remove arbitrary timeout from test_idle_maintenance.js and test_idle_maintenance_and_databases.js; r=#dom-storage

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:janv, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 13

[Jan Varga [:janv]]

Yeah, going to land these soon.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbc31ef7bbae
Add Maintenance::OnResults; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/ae344761679c
Add QuotaClient::DoMaintenance; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/b04e41dc0099
Bring back nsIIndexedDatabaseManager; r=dom-storage-reviewers,asuth

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68040a78053
Remove obsolete comment; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/3fcac65bf541
Extract background actor creation into a separate function; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/737164009733
Extract CreatePromise to PromiseUtils.h; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/2531abda5d95
Extract ResolveBoolResponseAndReturn to ErrorHandling.h; r=dom-storage-reviewers,asuth

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dbc31ef7bbae
https://hg.mozilla.org/mozilla-central/rev/ae344761679c
https://hg.mozilla.org/mozilla-central/rev/b04e41dc0099

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64f683ef6d14
Add nsIIndexedDatabaseManager::DoMaintenance; r=dom-storage-reviewers,asuth

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3604831a673
Verify that idle-daily notification triggers maintenance; r=dom-storage-reviewers,asuth

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f24d308576e7
Remove arbitrary timeout from test_idle_maintenance.js and test_idle_maintenance_and_databases.js; r=dom-storage-reviewers,asuth

Comment 20

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a68040a78053
https://hg.mozilla.org/mozilla-central/rev/3fcac65bf541
https://hg.mozilla.org/mozilla-central/rev/737164009733
https://hg.mozilla.org/mozilla-central/rev/2531abda5d95

Comment 21

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/64f683ef6d14
https://hg.mozilla.org/mozilla-central/rev/e3604831a673

Comment 22

[Jan Varga [:janv]]

So once the last patch gets to mozilla-central, both tests test_idle_maintenance.js and test_idle_maintenance_and_databases.js will take less than a second on a dev machine. It used to be at least 10s.

Comment 23

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f24d308576e7