1888932 - [wpt-sync] Sync PR 45449 - Revert "Use typed promises/resolvers for ReadableStream and related classes"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45449 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45449
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Revert "Use typed promises/resolvers for ReadableStream and related classes"

This reverts commit 4b6caa33d92a1610066f91809404aee6ce1ddb57.

Reason for revert: Lots of crash reports:
crbug.com/332153735
crbug.com/332046807

Original change's description:

Use typed promises/resolvers for ReadableStream and related classes

This converts IDL-exposed promises in ReadableStream,
ReadableStreamBYOBReader, ReadableStreamDefaultReader, and
ReadableStreamGenericReader to use typed ScriptPromiseResolver
instead of StreamPromiseResolver and to return typed
ScriptPromises.

Bug: 329702363
Change-Id: I94603a4ec7ffc9fa8d073d0746cfb6c1edae7109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373206
Reviewed-by: Adam Rice \<[e-mail]>
Commit-Queue: Nate Chapin \<[e-mail]>
Reviewed-by: Nidhi Jaju \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1280303}

Bug: 329702363
Change-Id: I9925ff950623f1db954590fa3b1d54fce6309119

Reviewed-on: https://chromium-review.googlesource.com/5405919
WPT-Export-Revision: b9cb5e55cb378733fc034212474cc348e7f21f76

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

ERROR: 2

Chrome

OK : 2
PASS : 4

Safari

ERROR: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /long-animation-frame/tentative/loaf-stream-source-location.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /long-animation-frame/tentative/loaf-stream.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/444a0a13f829
[wpt PR 45449] - Revert "Use typed promises/resolvers for ReadableStream and related classes", a=testonly

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/444a0a13f829