1888975 - Investigate how to share validations between Firefox desktop and Firefox for Android

Status: RESOLVED FIXED

(WebExtensions :: Android, task, P2)

Description

[Arturo Mejia [:amejia]]

We have these validations which are in the Firefox fron-end but they are also useful for Firefox for Android
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/content/aboutaddons.js#2452-2493

Comment 1

[William Durand [:willdurand]]

Ideally, we'd also share the same logic for the permissions API: https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/toolkit/components/extensions/parent/ext-permissions.js#81-97

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Assigning to Tom (as it was already the case for the related jira ticket) and added it as a blocker for Bug 1796176 (and set priority to match the one from the dependant bugzilla issue)

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1888975 - Move common optional permissions validation to ExtensionPermissions.sys.mjs r?willdurand

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ceb34e525f4
Move common optional permissions validation to ExtensionPermissions.sys.mjs r=willdurand

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ toolkit/mozapps/extensions/test/browser/browser_html_detail_permissions.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b2e191c66b1134a64397781e39e7d230f550ae4d

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_permissions.js | Uncaught exception in test bound testPermissionsViewStates

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c95498a244de
Move common optional permissions validation to ExtensionPermissions.sys.mjs r=willdurand

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c95498a244de