1889010 - [wpt-sync] Sync PR 45462 - Remove ASSERT_NO_EXCEPTION for toggling <select> popovers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45462 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45462
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Remove ASSERT_NO_EXCEPTION for toggling <select> popovers

I remembered that HidePopoverInternal and ShowPopoverInternal don't need
to take ExceptionStates for internal toggling like this, so I am
removing the ASSERT_NO_EXCEPTIONs so that we don't make it crash.

Bug: 1511354
Change-Id: Ifd4a6b2a2bf7167e3e361ff447cffe34e9668d89

Reviewed-on: https://chromium-review.googlesource.com/5384726
WPT-Export-Revision: 5c19eab54b84f2ca2ff41605775bb1a6ffbfadc1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=40712554c77cc96b33f39091fa112e3254709d0f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
PASS: 3
FAIL: 3

Safari

OK : 1
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/stylable-select/select-datalist-popover-behavior.tentative.html [wpt.fyi]
  • showPopover and hidePopover should work on the select datalist.: FAIL (Chrome: PASS, Safari: FAIL)
  • showPicker should show the select datalist.: FAIL (Chrome: FAIL, Safari: FAIL)
  • preventDefault on beforetoggle should prevent the datalist from showing.: FAIL (Chrome: PASS, Safari: FAIL)
  • showPopover on a disconnected datalist should throw an exception.: FAIL (Chrome: PASS, Safari: FAIL)
  • Disconnecting while internally showing the datalist should not crash or show the popover.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Disconnecting while internally hiding the datalist should not crash.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b98263ac9f
[wpt PR 45462] - Remove ASSERT_NO_EXCEPTION for toggling <select> popovers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/db01d8fdcfc8
[wpt PR 45462] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/41b98263ac9f
https://hg.mozilla.org/mozilla-central/rev/db01d8fdcfc8