1889080 - RemoteLazyInputStreamThread::Dispatch should use the overloaded Unused operator to leak

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Jens Stutte [:jstutte]]

See nika's bug 1767344 comment 94:

The failure in https://searchfox.org/mozilla-central/rev/28cc363411d2029aed04c969c8f98785cae110db/dom/file/ipc/RemoteLazyInputStreamThread.cpp#154 is a minor bug, because the already_AddRefed is leaked by casting to (void). This does leak the reference in release builds, but will hit this assertion in debug builds.

In order to avoid the assertion you need to use the Unused << overloaded operator (https://searchfox.org/mozilla-central/rev/28cc363411d2029aed04c969c8f98785cae110db/mfbt/AlreadyAddRefed.h#142-150).

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1889080 - Use overloaded Unused operator to leak runnable in RemoteLazyInputStreamThread::Dispatch. r?#dom-storage-reviewers

Comment 2

[Jens Stutte [:jstutte]]

This is just creating noise in debug builds, there is no effect on users.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e98689b9af
Use overloaded Unused operator to leak runnable in RemoteLazyInputStreamThread::Dispatch. r=dom-storage-reviewers,janv

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/99e98689b9af

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jstutte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.