1889120 - [siglist] Add Rust sub-slice accesses to the prefix list

Status: RESOLVED FIXED

(Socorro :: Signature, defect, P3)

Description

[Erich Gubler [:ErichDonGubler]]

I've noticed that some crashes are incorrectly being aggregated together because slice index accesses of slices (e.g., using a 2..4 "index" in the expr. slice[2..4], which I'll refer to as "sub-slice accesses" to hopefully be more clear) are not part of the prefix list. The frames that don't already appear to be part of the prefix list are:

• <core::ops::range::Range<usize> as core::slice::index::SliceIndex<[T]>>::index
• core::slice::index::<impl core::ops::index::Index<I> for [T]>::index

Comment 1

[Erich Gubler [:ErichDonGubler]]

Example: bug 1885339's crash reports have frames for:

• Report 039b22bf-6bce-423e-8996-a93560240313 should be associated with WebGPU:

  <core::ops::range::Range<usize> as core::slice::index::SliceIndex<[T]>>::index 
  core::slice::index::<impl core::ops::index::Index<I> for [T]>::index 
  wgpu_hal::metal::device::<impl wgpu_hal::Device<wgpu_hal::metal::Api> for wgpu_hal::metal::Device>::create_bind_group 
  

• Report a3354fdd-a972-46d5-9407-7c3b30240329 should be associated with WebRender:

  <core::ops::range::Range<usize> as core::slice::index::SliceIndex<[T]>>::index
  core::slice::index::<impl core::ops::index::Index<I> for [T]>::index
  webrender::scene_building::SceneBuilder::finalize_picture
  

Comment 2

[Erich Gubler [:ErichDonGubler]]

Filed a PR upstream at socorro#6568. Hopefully that makes this easy. 🙂 Happy to have this assigned to me, too, if that helps.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/socorro] bug-1889120: add Rust sub-slice access frames to prefix signature list (#6568)

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/socorro]: bug-1889120: add Rust sub-slice access frames to prefix signature list (#6568) in f457af1.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This deployed to production just now in bug #1890341.