1889239 - [rustc 1.79] error: field `is_new_scene` is never read

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

Building with rustc 1.79 (nightly) fails with the following errors:

[task 2024-04-02T07:45:01.817Z] 07:45:01    ERROR -  error: field `is_new_scene` is never read
[task 2024-04-02T07:45:01.817Z] 07:45:01     INFO -     --> gfx/wr/webrender/src/internal_types.rs:694:9
[task 2024-04-02T07:45:01.817Z] 07:45:01     INFO -      |
[task 2024-04-02T07:45:01.817Z] 07:45:01     INFO -  692 | pub struct RenderedDocument {
[task 2024-04-02T07:45:01.817Z] 07:45:01     INFO -      |            ---------------- field in this struct
[task 2024-04-02T07:45:01.817Z] 07:45:01     INFO -  693 |     pub frame: Frame,
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -  694 |     pub is_new_scene: bool,
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      |         ^^^^^^^^^^^^
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      |
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      = note: `-D dead-code` implied by `-D warnings`
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-04-02T07:45:01.818Z] 07:45:01    ERROR -  error: field `old_id` is never read
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -     --> gfx/wr/webrender/src/texture_pack/mod.rs:307:9
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      |
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -  305 | pub struct CompactionChange {
[task 2024-04-02T07:45:01.818Z] 07:45:01     INFO -      |            ---------------- field in this struct
[task 2024-04-02T07:45:01.819Z] 07:45:01     INFO -  306 |     pub handle: TextureCacheHandle,
[task 2024-04-02T07:45:01.819Z] 07:45:01     INFO -  307 |     pub old_id: AllocId,
[task 2024-04-02T07:45:01.819Z] 07:45:01     INFO -      |         ^^^^^^
[task 2024-04-02T07:45:01.819Z] 07:45:01    ERROR -  error: could not compile `webrender` (lib) due to 2 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1889239 - Remove unused RenderedDocument::is_new_scene and CompactionChange::old_id.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2129b0036dab
Remove unused RenderedDocument::is_new_scene and CompactionChange::old_id. r=gfx-reviewers,gw

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2129b0036dab