Closed Bug 1889350 Opened 3 months ago Closed 2 months ago

Broken import in eslint-plugin-mozilla's chrome-worker.js

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: aminomancer, Assigned: aminomancer)

References

Details

Attachments

(1 file)

This line should be changed to fix the import. This isn't supposed to trigger unless the chrome-worker environment is used, but for some mysterious reason I'm encountering it even though I only use browser-window. Still, it's worth fixing as long as the code exists.

diff --git a/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/chrome-worker.js b/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/chrome-worker.js
index db5759b26c3ec..a00b55401bdcc 100644
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/chrome-worker.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/chrome-worker.js
@@ -10,7 +10,7 @@
 
 "use strict";
 
-var globals = require("globals");
+var globals = require("../globals");
 var util = require("util");
 
 var workerGlobals = util._extend(
Assignee: nobody → shughes
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(bpostelnicu)
Attachment #9394741 - Attachment description: Bug 1889350 - Fix a broken import in eslint-plugin-mozilla. r=Standard8 → Bug 1889350 - Remove chrome-worker environment from eslint-plugin-mozilla. r=Standard8
Severity: -- → S3
Flags: needinfo?(bpostelnicu)
Pushed by shughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cdd31c08963
Remove chrome-worker environment from eslint-plugin-mozilla. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: