1889444 - Record a Glean event for sites purged by Bounce Tracking Protection

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Paul Zühlcke [:pbz]]

These events should be Nightly only since they include the site host that has been purged. This data will be essential for determining the false positive detection rate of the feature.

Here is a draft:

bounce.tracking.protection:
  action_purge:
    type: event
    description: >
      Dispatched whenever a bounce tracker site is purged.
    bugs:
      - https://bugzilla.mozilla.org/xxxxxx
    data_reviews:
      - https://bugzilla.mozilla.org/show_bug.cgi?id=xxxxxxx
    data_sensitivity:
      - stored_content
    notification_emails:
      - [e-mail]
      - [e-mail]
    expires: never
    extra_keys:
      site_host:
        description: The site host of which the data has been purged.
        type: string
      bounce_time:
        description: Timestamp (seconds since epoch) of the last detected bounce.
        type: quantity
      success:
        description: Whether the purge data call was successful. false indicates an error in ClearDataService.
        type: boolean

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1889444 - Record a Glean event for sites purged by Bounce Tracking Protection. r=bvandersloot!

The event is only collected in pre-release channels, since it contains siteHost which is considered
category 3 data.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1889444 - Test for Bounce Tracking Protection purge Glean event. r=bvandersloot!

Comment 3

[[e-mail]]

Attachment: Bounce Tracking Protection Telemetry Event in Nightly

Based on the context outlined in this document, as well as the Fabricator patch and the fact this is for Nightly users and not collecting the specific domain a user navigated to but instead the purged URI of the bounce tracker host, I believe this collection qualifies as Cat 2 and passes review.

Comment 4

[Paul Zühlcke [:pbz]]

Thanks Cameron! For clarification: we don't report the full URI, but only the site host (eTLD+1). Also strictly speaking this new event isn't only collected in Nightly, but Nightly and early Beta, as is usually for pre-release telemetry or experiments. I Just want to make sure that this doesn't change your verdict here. Thanks!

Comment 5

[Paul Zühlcke [:pbz]]

Cameron confirmed via DM.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cd441010547
Record a Glean event for sites purged by Bounce Tracking Protection. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/45c9c902f35f
Test for Bounce Tracking Protection purge Glean event. r=bvandersloot,anti-tracking-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcee8826f797
Record a Glean event for sites purged by Bounce Tracking Protection. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/3f3c9202fe55
Test for Bounce Tracking Protection purge Glean event. r=bvandersloot,anti-tracking-reviewers

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/dcee8826f797
https://hg.mozilla.org/mozilla-central/rev/3f3c9202fe55

Comment 9

[Paul Zühlcke [:pbz]]

Attachment: Revert "Bug 1889444 - Record a Glean event for sites purged by Bounce Tracking Protection." r=bvandersloot!

This reverts commit d13642ffba96ff2b73f1b442387fbea6f986fdab.

Comment 10

[Paul Zühlcke [:pbz]]

Attachment: Revert "Bug 1889444 - Test for Bounce Tracking Protection purge Glean event." r=bvandersloot!

This reverts commit 48bde0422353201d2c978de5311a8706ac95d72b.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8695bd678933
Revert "Bug 1889444 - Record a Glean event for sites purged by Bounce Tracking Protection." r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/00cff0524b7b
Revert "Bug 1889444 - Test for Bounce Tracking Protection purge Glean event." r=bvandersloot,anti-tracking-reviewers

Comment 12

[Cristian Tuns]

Revert merged to central: https://hg.mozilla.org/mozilla-central/rev/8695bd678933
https://hg.mozilla.org/mozilla-central/rev/00cff0524b7b

Comment 13

[Paul Zühlcke [:pbz]]

Attachment: Bug 1889444 - Add BTP purge Glean event. r=#anti-tracking!

Comment 14

[Paul Zühlcke [:pbz]]

Attachment: Bug 1889444 - Submit BTP custom ping on idle-daily. r=#anti-tracking!

Comment 15

[Paul Zühlcke [:pbz]]

Attachment: Bug 1889444 - Tests, r=#anti-tracking!

Comment 16

[[e-mail]]

Comment on attachment 9405286 [details]
Bug 1889444 - Tests, r=#anti-tracking!

Changes made to address data steward recommendations

Comment 19

[Nneka]

Confirming that team agreed to data steward recommendations of 1) treating pre-release and release the same, 2) using OHTTP in both, and 3) removing client ID for both. Patch drafts created and no further issues on our side, thanks!

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6101f2573e20
Add BTP purge Glean event. r=anti-tracking-reviewers,manuel,data-stewards
https://hg.mozilla.org/integration/autoland/rev/18701634fe7e
Submit BTP custom ping on idle-daily. r=anti-tracking-reviewers,manuel
https://hg.mozilla.org/integration/autoland/rev/8a7a6ad6efe0
Tests, r=anti-tracking-reviewers,manuel

Comment 21

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages in ClearDataCallback.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/ClearDataCallback.h(37,10): error: private field 'mBounceTime' is not used [-Werror,-Wunused-private-field]

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/794e7b951f29
Add BTP purge Glean event. r=anti-tracking-reviewers,manuel,data-stewards
https://hg.mozilla.org/integration/autoland/rev/3b1dc8369d98
Submit BTP custom ping on idle-daily. r=anti-tracking-reviewers,manuel
https://hg.mozilla.org/integration/autoland/rev/40bffb571031
Tests, r=anti-tracking-reviewers,manuel

Comment 23

[pstanciu]

Backed out for causing xpcshell failures on test_JOG.js

• Backout link
• Push with failures
• Failure Log

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11dfe3f3bad6
Add BTP purge Glean event. r=anti-tracking-reviewers,manuel,data-stewards
https://hg.mozilla.org/integration/autoland/rev/4e5b69dba375
Submit BTP custom ping on idle-daily. r=anti-tracking-reviewers,manuel
https://hg.mozilla.org/integration/autoland/rev/ac73c5d0e3ee
Tests, r=anti-tracking-reviewers,manuel

Comment 25

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/11dfe3f3bad6
https://hg.mozilla.org/mozilla-central/rev/4e5b69dba375
https://hg.mozilla.org/mozilla-central/rev/ac73c5d0e3ee