1889496 - Implement parsing for @starting-style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1889496 - Part 1: Parse @starting-style rule.

We introduce this rule and parse it in this patch. Also, fix some wpt
expectations for ERROR.

We will introduce CSSStartingStyleRule in the following patch, and test
it there.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1889496 - Part 2: Implement CSSStartingStyleRule interface.

Introduce CSSStartingStyleRule and add one extra parsing test for
@starting-style rule.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abbbf327c4f1
Part 1: Parse @starting-style rule. r=layout-reviewers,firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/7689f9c266fc
Part 2: Implement CSSStartingStyleRule interface. r=webidl,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45562 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:48:37: error: member access into incomplete type 'nsPluginElement'

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Boris Chiou [:boris]]

The try looks good. Perhaps someone landed a patch and my patch may find a missing inclusion after that.

I will push to try again tomorrow after the tree updates.

Comment 8

[Boris Chiou [:boris]]

Attachment: Bug 1889496 - Fix the potential incomplete type when accessing nsPluginElement with RefPtr.

We may get build bustages for fuzzy build without this change:
member access into incomplete type 'nsPluginElement'.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1889496#c5.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2aac9b9535b
Fix the potential incomplete type when accessing nsPluginElement with RefPtr. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/3dcf1e33c55b
Part 1: Parse @starting-style rule. r=layout-reviewers,firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/af6a46f044fb
Part 2: Implement CSSStartingStyleRule interface. r=webidl,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f2aac9b9535b
https://hg.mozilla.org/mozilla-central/rev/3dcf1e33c55b
https://hg.mozilla.org/mozilla-central/rev/af6a46f044fb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot