1889607 - Invitations sent twice (from TB and caldav server) when calendar associated email is wrong (case sensitive !)

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Merome]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0

Steps to reproduce:

1. On a CALDAV server (tested here with Nextcloud 28.0.4), create a calendar associated with this email address : [e-mail]
2. On TB 115.9.0, add the caldav calendar associated with this email address : [e-mail] (same address but some chars are uppercase)
3. Check the prefer client-side email scheduling checkbox
4. Create an event and invite [e-mail]

Actual results:

[e-mail] receives 2 invitations : one from Thunderbird and one from the Caldav server.

[e-mail] also receives a Thunderbird forged invitation coming from [e-mail] (uppercase)

Expected results:

As we have checked client-side scheduling, only one invitation should have been sent, by Thunderbird only and to [e-mail] only.

Comment 1

[Merome]

Here is some relevant additional information :
When TB sends the VCALENDAR Object to the caldav server, he "forgets" to set the "SCHEDULE-AGENT=CLIENT" information, we can see it on the Network console :

When the caldav server address === TB calendar address, all is fine, attendees have both "SCHEDULE-AGENT=CLIENT" information :

UID:44e971c3-b3be-45ff-b9b8-8c0921004be9
SUMMARY:test
ORGANIZER;PARTSTAT=NEEDS-ACTION;CUTYPE=INDIVIDUAL:mailto:[e-mail]
ATTENDEE;PARTSTAT=ACCEPTED;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;SCHEDULE-
 AGENT=CLIENT:mailto:[e-mail]
ATTENDEE;CN=Someone;PARTSTAT=NEEDS-ACTION;CUTYPE=INDIVIDUAL;ROLE=REQ-
 PARTICIPANT;SCHEDULE-AGENT=CLIENT:mailto:[e-mail]

When the caldav server address differs from the TB calendar address (uppercase on some characters), the VCAL object sent by TB to the caldav doesn't mention the "SCHEDULE-AGENT=client" anymore for the attendees and the organizer has now this flag on :

UID:48daf6b9-6016-4771-9bdf-373b4295023f
SUMMARY:test
ORGANIZER;PARTSTAT=NEEDS-ACTION;CUTYPE=INDIVIDUAL;SCHEDULE-AGENT=CLIENT:mai
 lto:[e-mail]
ATTENDEE;PARTSTAT=ACCEPTED;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT:mailto:el
 [e-mail]
ATTENDEE;CN=Someone;PARTSTAT=NEEDS-ACTION;CUTYPE=INDIVIDUAL;ROLE=REQ-
 PARTICIPANT:mailto:[e-mail]

Note that on this VCAL object, all email address are lowercase in both case. Normalization of the addresses is processed somewhere, but at one point, Thunderbird think [e-mail] != [e-mail] and it breaks the client-side scheduling.

It can be related to another "case sensitive" bug : https://bugzilla.mozilla.org/show_bug.cgi?id=1878944

Comment 2

[Magnus Melin [:mkmelin]]

Maybe https://searchfox.org/comm-central/rev/26add62bc1f8d7828ee118a39e2565b04767149e/calendar/base/content/dialogs/calendar-dialog-utils.js#588

Comment 3

[Merome]

Tested on TB 128.0esr, the problem is still present.

Workaround for Nextcloud users :
in protected function parseEventInfo(VCalendar $calendar = null) in the file /var/www/nextcloud/3rdparty/sabre/vobject/lib/ITip/Broker.php

after

                if ($this->scheduleAgentServerRules &&
                    isset($attendee['SCHEDULE-AGENT']) &&
                    'CLIENT' === strtoupper($attendee['SCHEDULE-AGENT']->getValue())
                ) {
                    continue;
                }

Add these lines

            // Prevent Nextcloud to send invitation already sent by Thunderbird when associated email address is not exactly the same
            if(strpos(strtolower($calendar->PRODID),"mozilla")!==false)

            {

                    continue;

            } 

Bug #1878944 seems to be resolved on TB128, so there is no relation between these 2 bugs.

Comment 4

[Merome]

Thunderbird 128.4.3 / Nextcloud 30.0.2

I've just upgraded Nextcloud from 29.X to 30.0.2 and I forgot to apply my dirty patch mentioned above. Immediately, new invitations are coming twice.

Same problem with accept/decline message => they are received twice by the organizer.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1889607 - Invitations sent twice (from TB and caldav server) when calendar associated email does not case match exact case. r=#thunderbird-reviewers

Fix some case sensitivity issues.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13a73a665f73
Invitations sent twice (from TB and caldav server) when calendar associated email does not case match exact case. r=arschmitz

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9445658 [details]
Bug 1889607 - Invitations sent twice (from TB and caldav server) when calendar associated email does not case match exact case. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: may get double invitations
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): safe, just case sensitivity ignoring in lookup

Comment 8

[Corey Bryant]

Comment on attachment 9445658 [details]
Bug 1889607 - Invitations sent twice (from TB and caldav server) when calendar associated email does not case match exact case. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.6.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/22b3993f9f39