1889840 - will never use an entry in the image cache when loading an image top level that has a redirect

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

When loading a uri with a redirect at the top level we search the cache using the current uri (ie after the redirect)

https://searchfox.org/mozilla-central/rev/b5b551329484a67f2abb4bae50411b93d5851733/image/imgLoader.cpp#2611

but we store the image in the cache using the original uri (before the redirect)

https://searchfox.org/mozilla-central/rev/b5b551329484a67f2abb4bae50411b93d5851733/image/imgLoader.cpp#2724

(you can see a comment mentioning this issue there).

This behaviour was introduced in bug 121084 21 years ago where they were aware that the patch was introducing this problem but accepted the patch because it solved more problems then it caused (bug 121084, comment 214, bug 121084, comment 216).

This came up in bug 1838350.

Comment 1

[Timothy Nikkel (:tnikkel)]

I tried pushing to try looking up the original uri in the cache to try and it does fail a couple of tests.