1889931 - Collect native CSS system-colors

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Tom Schuster (MoCo)]

There are a number of CSS system-colors that we query from the operating system and might be modified by the user's theming options (Especially on Linux/GTK).

We have a list of all system-colors (typedef as ColorID in C++) define in Rust here: SystemColor. Furthermore we have a list of system colors which we have hardcoded values for (so called stand-ins?): sNonNativeThemeStandinColors.

However we don't always use those hard-coded stand-ins, the most interesting condition is the check for high-contrast mode: aPrefs.NonNativeThemeShouldBeHighContrast(). I am not sure if we already collect this value. At first brush it seems different to prefers-contrast.

Comment 1

[Tom Schuster (MoCo)]

Attachment: Exposed native CSS system colors

Unless I made a mistake, I think we expose 66 colors. We probably don't need to collect all of them, but just those that are more commonly customized like Accentcolor.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Most of those are not exposed, actually, the Headerbar colors for example are not parsed in content. The IME and attention colors are also not parsed due to this #[css(skip)] here.

Comment 3

[Tom Schuster (MoCo)]

Nice, thanks emilio. I think that just leave us with:

Accentcolor
Accentcolortext
Canvas
Canvastext
Highlight
Highlighttext
Mark
Marktext
MozCellhighlight
MozCellhighlighttext
MozDialog
MozDialogtext
MozEventreerow
MozMenubarhovertext
MozMenuhover
MozMenuhovertext
MozOddtreerow
Selecteditem
Selecteditemtext

Comment 4

[Emilio Cobos Álvarez (:emilio)]

The Moz* ones we can probably unexpose from content at this point.

The Mark / MarkText ones are hard-coded already.

Canvas / CanvasText are prefable / settable from the color dialog in settings, but the defaults are also hard-coded in practice.

So that leaves Accentcolor, Highlight, and SelectedItem, which are all generally derived from the accent color.

Comment 5

[Tom Schuster (MoCo)]

Attachment: Bug 1889931 - Collect native CSS system-colors. r?timhuang

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc2f2927636
Collect native CSS system-colors. r=emilio,tjr

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cc2f2927636