1889941 - Partial restoration of closed windows with 'Reopen all windows' option in History menu

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Ina Popescu, Desktop QA]

Found in

• Firefox 125.0b8

Affected versions

• Nightly 126.0a1
• Firefox 124.0.2
• Firefox 125.0b8

Tested platforms

• Affected platforms: All
• Unaffected platforms: None

Steps to reproduce

1. Open Firefox using a new profile
2. Use the "New Window" option from the side menu to open several new windows(three in this instance)
3. Close all previously opened windows except one
4. Use the "Reopen all windows" option from History > Recently closed windows

Expected result

• All previously closed windows are restored.

Actual result

• Only two windows are restored out of the three previously closed when using the "Reopen all windows" option from History > Recently closed windows.

Regression range
Regression range narrowed down to:

• Last good revision: db66b8bc0dca08a4b3c1864ee10fc7c903071f88
• First bad revision: 0df1e23ae51110611b7429b661209b84916d0203
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db66b8bc0dca08a4b3c1864ee10fc7c903071f88&tochange=0df1e23ae51110611b7429b661209b84916d0203

However, I'll double-check before confirming the culprit to be Bug 1819675.

Comment 1

[Ina Popescu, Desktop QA]

I've double-checked the regression range for this issue, and it seems that the same culprit, Bug 1819675, has appeared

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1819675, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Thanks for tracking down the regressor.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819675

Comment 5

[Pascal Chevrel:pascalc]

Sam, is that a bug that will get fixed in 127? Thanks

Comment 6

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1889941 - Fix the restore all windows command. r?#sessionstore-reviewers!

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #5)

Sam, is that a bug that will get fixed in 127? Thanks

Yes! I've put a patch on here for review. Its pretty simple, I don't anticipate any issue getting it into 127.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c73a9f86487
Fix the restore all windows command. r=sessionstore-reviewers,farre

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6c73a9f86487

Comment 10

[Ina Popescu, Desktop QA]

I've replicated this issue using 126.0a1 (2024-04-05) on Windows 10 x64.
Verified as fixed in the latest Nightly 127.0a1 version on Windows 10 x64, macOS 13, and Ubuntu 22.04, as the issue no longer occurs.