1889988 - Add remote settings configuration of defaultURI bypass list

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[edgul]

Enabling defaultURI (rust-url) as our default parser for unknown/fallback schemes in Bug 1603699 introduced significant breakage.
In addition to the user-specified list for custom schemes to bypass defaultURI as the fallback parser in Bug 1878001, this bug aims to provide a list of common custom schemes that currently encounter breakage during URL parsing with the defaultURI parser so that firefox can fallback to using simpleURI parser. We chose Remote Settings to distribute the list so that as we encounter schemes with enough breakage we can easily add to and deploy the list.

Comment 1

[edgul]

Attachment: Bug 1889988 - Added remote settings input to defaultUri bypass list r?valentin

Comment 2

[edgul]

Attachment: Bug 1889988 - Re-enable defaultURI as parser for unknown schemes and update tests. r?valentin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/360a3d2b1200
Added remote settings input to defaultUri bypass list r=necko-reviewers,valentin,nika,Standard8
https://hg.mozilla.org/integration/autoland/rev/db199aeaafd8
Re-enable defaultURI as parser for unknown schemes r=valentin

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out 2 changesets (Bug 1889988) for xpcshell failures on test_getPasswordOrigin.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=db199aeaafd887bffc7eac4142eef50cca23a4b9&selectedTaskRun=MZ9jTsvxTPqIvtStYPRFeg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=479454644&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/61f7d9c0998e2ce8008cd15b187f86dfdba21a26

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc4966854945
Added remote settings input to defaultUri bypass list r=necko-reviewers,valentin,nika,Standard8
https://hg.mozilla.org/integration/autoland/rev/b0ed8cbb2bd1
Re-enable defaultURI as parser for unknown schemes and update tests. r=valentin,bvandersloot

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fc4966854945
https://hg.mozilla.org/mozilla-central/rev/b0ed8cbb2bd1

Comment 7

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: WIP: Backed out 2 changesets (Bug 1889988) for xpcshell failures on test_getPasswordOrigin. CLOSED TREE

Backed out changeset db199aeaafd8 (bug 1889988)
Backed out changeset 360a3d2b1200 (bug 1889988)

Comment 8

[Alex Finder]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc4966854945
Added remote settings input to defaultUri bypass list
r=necko-reviewers,valentin,nika,Standard8
https://hg.mozilla.org/integration/autoland/rev/b0ed8cbb2bd1
Re-enable defaultURI as parser for unknown schemes and update tests.
r=valentin,bvandersloot

Perfherder has detected a build_metrics performance change from push b0ed8cbb2bd1091e2377160589569c3972231e1a.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	compiler_metrics num_static_constructors	osx-aarch64-shippable	aarch64	89.00 -> 88.00
1%	compiler_metrics num_static_constructors	osx-cross		91.00 -> 90.00
1%	compiler_metrics num_static_constructors	windows2012-64-shippable		98.00 -> 97.00
1%	compiler_metrics num_static_constructors	linux64		105.00 -> 104.00
1%	compiler_metrics num_static_constructors	windows2012-32		108.00 -> 107.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42631

For more information on performance sheriffing please see our FAQ.