1890011 - Crash in [@ java.lang.NumberFormatException: at java.lang.Integer.parseInt(Integer.java)]

Status: RESOLVED FIXED

(Fenix :: Tooling, defect, P3)

Description

[eclaudiu64]

Crash report: https://crash-stats.mozilla.org/report/index/95b3884c-d525-4345-a148-eb6dd0240405

Java stack trace:

java.lang.NumberFormatException
	at java.lang.Integer.parseInt(Integer.java:618)
	at java.lang.Integer.parseInt(Integer.java:650)
	at org.mozilla.fenix.debugsettings.tabs.TabToolsKt$TabCreationTool$1$1$1.invoke(TabTools.kt:26)
	at androidx.compose.foundation.text.BasicTextFieldKt$BasicTextField$4$1.invoke(BasicTextField.kt:40)
	at androidx.compose.foundation.text.TextFieldState$onValueChange$1.invoke(CoreTextField.kt:37)
	at androidx.compose.foundation.text.TextFieldKeyInput.apply(TextFieldKeyInput.kt:24)
	at androidx.compose.foundation.text.TextFieldKeyInputKt$textFieldKeyInput$2$1.invoke(TextFieldKeyInput.kt:146)
	at androidx.compose.ui.input.key.KeyInputNode.onKeyEvent-ZmokQxo(KeyInputModifier.kt:15)
	at androidx.compose.ui.focus.FocusOwnerImpl.dispatchKeyEvent-ZmokQxo(FocusOwnerImpl.kt:446)
	at androidx.compose.ui.platform.AndroidComposeView.dispatchKeyEvent(AndroidComposeView.android.kt:35)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1986)
	at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:903)
	at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1947)
	at android.app.Activity.dispatchKeyEvent(Activity.java:4142)
	at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:1)
	at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:11)
	at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:19)
	at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:23)
	at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:20)
	at io.sentry.android.core.internal.gestures.WindowCallbackAdapter.dispatchKeyEvent(WindowCallbackAdapter.java:3)
	at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:758)
	at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:7365)
	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7191)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6595)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6652)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6618)
	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6786)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6626)
	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6843)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6599)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6652)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6618)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6626)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6599)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:9880)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:9718)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:9671)
	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6206)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:246)
	at android.app.ActivityThread.main(ActivityThread.java:8653)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

Comment 1

[jackyzy823]

STR:

1. Enable Debug Drawer in Secret Menu
2. In "Debug Drawer" set "tab quantity to create" to a large number which is exceeded the max of Int (for example repeatedly press 9 until it crashes)

Comment 2

[jackyzy823]

Attachment: Bug 1890011 - Prevent parseInt error in Debug drawer. r=#android-reviewers

Comment 3

[Nicholas Poon [:Nick]]

This issue was fixed in Bug 1890390, where the validation logic was refactored into a function validateTextField. Therefore, I will close this bug as FIXED.