Closed
Bug 1890101
Opened 6 months ago
Closed 6 months ago
Use NSTitlebarAccessoryViewController as per the apple docs.
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
126 Branch
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•6 months ago
|
||
|
|
Assignee | |
Comment 2•6 months ago
|
||
From https://developer.apple.com/documentation/appkit/nstitlebaraccessoryviewcontroller?language=objc
Don’t override the view property in your
NSTitlebarAccessoryViewController subclass. Instead, you can override
loadView, and set the view property in that method.
This partially fixes bug 1889442, see the comments there, and should be
uncontroversial.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/811b1e2c8724
Remove some dead code in nsCocoaWindow.mm. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/3dd17c1ec3ef
Tweak titlebar accessory view setup to follow macOS docs. r=mac-reviewers,bradwerth
|
||
Comment 4•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/811b1e2c8724
https://hg.mozilla.org/mozilla-central/rev/3dd17c1ec3ef
Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox126:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•