Open
Bug 1890196
Opened 6 months ago
Updated 3 months ago
Update ReadExtensionPrefs in Preferences.cpp
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.53? affected)
ASSIGNED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.19)
Attachments
(1 file)
|
2.06 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Currently ReadExtensionPrefs reads the files it finds in chunks of 4096 which seems to cause problems when backporting bug 1423840.
Using something similar to LoadEntry in nsJAR.cpp should work better:
http://xr.thereisonlyxul.org/seamonkey-2.53/source/modules/libjar/nsJAR.cpp#331
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Cannot land bug 1423840
Testing completed (on m-c, etc.): 2.53.19
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9395433 -
Flags: review?(frgrahl)
Attachment #9395433 -
Flags: approval-comm-release?
|
||
Updated•3 months ago
|
|
|
||
Comment 2•3 months ago
|
||
Comment on attachment 9395433 [details] [diff] [review]
1890196-readextensionprefs-25319.patch
LGTM. Have not seen any fallout. Approved for our 2.53 mozilla branch
Attachment #9395433 -
Flags: review?(frgrahl)
Attachment #9395433 -
Flags: review+
Attachment #9395433 -
Flags: approval-comm-release?
Attachment #9395433 -
Flags: approval-comm-release+
You need to log in
before you can comment on or make changes to this bug.
Description
•