1890216 - Update Skia to m125

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P1)

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1890216 - Fix Skia API usage in Gecko for m125 update. r?aosmond

A number of public APIs in Skia have changed since the update to m125,
so various places in Gecko need to be updated to track it.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1890216 - Update moz.build for Skia m125 update. r?aosmond

Depends on D209821

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1890216 - Source files for Skia m125 update. r?aosmond

Depends on D209822

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1890216 - Fuzz for Skia m125 update. r?aosmond

Depends on D209823

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9014c3f367eb
Fix Skia API usage in Gecko for m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/9e684b8096fc
Update moz.build for Skia m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/9da95cf34386
Source files for Skia m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/31ffc16da37b
Fuzz for Skia m125 update. r=aosmond

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9014c3f367eb
https://hg.mozilla.org/mozilla-central/rev/9e684b8096fc
https://hg.mozilla.org/mozilla-central/rev/9da95cf34386
https://hg.mozilla.org/mozilla-central/rev/31ffc16da37b

Comment 7

[Iulian Moraru]

Backed out for causing multiple new permafailures. (please check the Regressions section)

• Push with failures

• Backout link

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please wait until after the soft freeze ends before attempting to re-land this.

Comment 9

[Alex Finder]

(In reply to Iulian Moraru from comment #7)

Backed out for causing multiple new permafailures. (please check the Regressions section)

• Push with failures

• Backout link

Perfherder has detected a build_metrics performance change from push 54407678e7820205d75b1342e18e82ee099acec2.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.21%	installer size	osx-cross		95,410,678.42 -> 95,209,089.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 202

For more information on performance sheriffing please see our FAQ.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5091e0b802e3
Fix Skia API usage in Gecko for m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/997476d957d6
Update moz.build for Skia m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/51514017aa02
Source files for Skia m125 update. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/aa970a5bf322
Fuzz for Skia m125 update. r=aosmond

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5091e0b802e3
https://hg.mozilla.org/mozilla-central/rev/997476d957d6
https://hg.mozilla.org/mozilla-central/rev/51514017aa02
https://hg.mozilla.org/mozilla-central/rev/aa970a5bf322