1890278 - _importJSONDump sometimes seem to escape its shutdown blocker

Status: NEW

(Firefox :: Remote Settings Client, defect)

Description

[Jens Stutte [:jstutte]]

From bug 1813353 it seems there can be situations where we enter shutdown while _importJSONDump is running. We might want to consider to harden this with a shutdown blocker.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Jens, it seems that we already have a shutdown blocker...

_importJSONDump calls the worker method RemoteSettingsWorker.importJSONDump:
https://searchfox.org/mozilla-central/rev/c09764753ea40725eb50decad2c51edecbd33308/services/settings/RemoteSettingsClient.sys.mjs#966-969

And we have a shutdown blocker that waits for worker callbacks to have finished:
https://searchfox.org/mozilla-central/rev/c09764753ea40725eb50decad2c51edecbd33308/services/settings/RemoteSettingsWorker.sys.mjs#182-219

I don't know where to start to debug this :/

Comment 2

[Jens Stutte [:jstutte]]

Could there be cases/races where gShutdown is never set and the after-shutdown check here will not work?

You could try to substitute the gShutdown checks with Services.startup.isInOrBeyondShutdownPhase(Ci.nsIAppStartup.SHUTDOWN_PHASE_APPSHUTDOWN), FWIW.

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:leplatrem, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Per https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity:

S1 (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available

Is that the correct severity for this bug?

Comment 5

[Mathieu Leplatre [:leplatrem]]

Oops. No. Sorry. Thank you for the heads up