1890325 - [mozrunner] TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str'

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Happens when running web-platform-tests on Android with the Fenix package:

mach wpt testing/web-platform/tests/dom --no-install --package org.mozilla.fenix

Traceback (most recent call last):
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 213, in init
    self.browser.start(group_metadata=group_metadata, **self.browser_settings)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 298, in start
    self.runner.start(debug_args=debug_args,
  File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/base/device.py", line 75, in start
    self.device.setup_profile(self.profile)
  File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/devices/base.py", line 122, in setup_profile
    config.write(new_profiles_ini)
  File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/devices/base.py", line 252, in write
    fp.write(b"[%s]\n" % section)
TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str'

By default the tempfile.NamedTemporaryFile opens in w+b mode while we are operating with strings here.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1890325 - [mozrunner] Do not use bytes mode when writing profile.ini data via NamedTemporaryFile.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1db5227c9878
[mozrunner] Do not use bytes mode when writing profile.ini data via NamedTemporaryFile. r=jgraham,gbrown

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/1db5227c9878