Closed Bug 1890414 Opened 2 months ago Closed 2 months ago

Scripts that relied on start-shell.bat blocking are broken with move to MinTTY

Categories

(Firefox Build System :: MozillaBuild, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: cmartin, Unassigned)

References

(Regression)

Details

(Keywords: regression)

I have a script on my machine that does some post-processing of a Firefox build after it finishes. I kick off the build using the following command line:

cmd /c start-shell.bat -where "<dir>\mozilla-unified" -c "./mach build"

Starting with the latest MozillaBuild update, a new MinTTY window is launched and control returns immediately from the invocation. Unfortunately, that means my post-processing script now races with the build.

Maybe there is some other way I should be doing this instead?

:ahochheiden, since you are the author of the regressor, bug 1869958, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(ahochheiden)

You can set the environment variable USE_MINTTY=0 and it will go back to the old behavior, which should solve your issue.

I'm not sure if there's a way to do exactly what you're doing with MinTTY since it's opening a new terminal and abandoning the old one. Is there a reason the post-processing specifically needs to happen outside of the MozillaBuild shell? It might be easier to have a script that calls ./mach build then your post-processing steps all within the MinTTY shell (but I'm not sure what exactly you're doing, so it may not be feasible).

Either way, I don't think there's much to do here. I'll leave this open to await your reply, but I will probably close this as WONTFIX.

Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(ahochheiden) → needinfo?(cmartin)
Severity: -- → S4
Priority: -- → P5

Alrighty -- I have set USE_MINTTY=0 and that did fix the issue. I will have to look into the idea of having my script call ./mach build, but I think I remember there being issues with that because of the way MinTTY handles paths. Thanks anyway -- Good to know that I'm not missing something here.

Status: UNCONFIRMED → RESOLVED
Closed: 2 months ago
Flags: needinfo?(cmartin)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.