1890428 - Implement Declarative ShadowDOM serialization

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Adam Vandolder [:avandolder]]

See the relevant WHATWG issue: https://github.com/whatwg/dom/pull/1256.

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1890428 - Add shadowrootserializable attribute. r?#dom-core

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: Bug 1890428 - Add serialization support for Declarative Shadow DOM. r?#dom-core

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37e2a10a9022
Add shadowrootserializable attribute. r=dom-core,hsivonen
https://hg.mozilla.org/integration/autoland/rev/f9cf0740eef2
Add serialization support for Declarative Shadow DOM. r=webidl,smaug

Comment 4

[Cristian Tuns]

Backed out for causing wpt failures in idlharness.window.html?exclude=Node

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /dom/idlharness.window.html?exclude=Node | ShadowRoot interface: attribute serializable - expected FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e45e3d15eed
Add shadowrootserializable attribute. r=dom-core,hsivonen
https://hg.mozilla.org/integration/autoland/rev/1954ce9669b8
Add serialization support for Declarative Shadow DOM. r=webidl,smaug

Comment 6

[tszentpeteri]

Backed out for causing wpt failures on idlharness.https.html.

• Backout link
• Push with failures
• Failure Log for wpt4
• Failure Log for wpt12
• Failure log:

[task 2024-05-15T07:41:47.161Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: attribute shadowRootClonable 
[task 2024-05-15T07:41:47.161Z] 07:41:47     INFO - TEST-UNEXPECTED-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: attribute shadowRootSerializable - expected FAIL
[task 2024-05-15T07:41:47.161Z] 07:41:47     INFO - TEST-INFO | expected FAIL
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement must be primary interface of document.createElement("template") 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | Stringification of document.createElement("template") 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: document.createElement("template") must inherit property "content" with the proper type 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: document.createElement("template") must inherit property "shadowRootMode" with the proper type 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: document.createElement("template") must inherit property "shadowRootDelegatesFocus" with the proper type 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: document.createElement("template") must inherit property "shadowRootClonable" with the proper type 
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-UNEXPECTED-PASS | /html/dom/idlharness.https.html?include=HTML.* | HTMLTemplateElement interface: document.createElement("template") must inherit property "shadowRootSerializable" with the proper type - expected FAIL
[task 2024-05-15T07:41:47.164Z] 07:41:47     INFO - TEST-INFO | expected FAIL
[task 2024-05-15T07:41:47.233Z] 07:41:47     INFO - ................................................................................................................................................................................................
[task 2024-05-15T07:41:47.233Z] 07:41:47     INFO - TEST-OK | /html/dom/idlharness.https.html?include=HTML.* | took 2470ms
[task 2024-05-15T07:41:47.235Z] 07:41:47     INFO - PID 2419 | 1715758907171	Marionette	INFO	Stopped listening on port 53208
[task 2024-05-15T07:41:47.805Z] 07:41:47     INFO - Browser exited with return code 0
[task 2024-05-15T07:41:47.807Z] 07:41:47     INFO - Closing logging queue
[task 2024-05-15T07:41:47.808Z] 07:41:47     INFO - queue closed
[task 2024-05-15T07:41:47.827Z] 07:41:47     INFO - Application command: /opt/worker/tasks/task_171575759055922/build/application/Firefox Nightly.app/Contents/MacOS/firefox --marionette about:blank -foreground -profile /var/folders/7w/w8_lzh355ld2fyl0vytvmcf4000014/T/tmp9ppxp_2p
[task 2024-05-15T07:41:47.834Z] 07:41:47     INFO - PID 2426 | 1715758903011	Marionette	INFO	Marionette enabled
[task 2024-05-15T07:41:47.835Z] 07:41:47     INFO - PID 2426 | 1715758903280	Marionette	INFO	Listening on port 53226
[task 2024-05-15T07:41:47.835Z] 07:41:47     INFO - PID 2426 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-05-15T07:41:47.836Z] 07:41:47     INFO - PID 2426 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-05-15T07:41:47.836Z] 07:41:47     INFO - Starting runner
[task 2024-05-15T07:41:48.165Z] 07:41:48     INFO - PID 2426 | 2024-05-15 07:41:48.164 firefox[2426:67047] Persistent UI failed to open file file:///Users/cltbld/Library/Saved%20Application%20State/org.mozilla.nightly.savedState/window_1.data: No such file or directory (2)
[task 2024-05-15T07:41:48.380Z] 07:41:48     INFO - TEST-START | /html/dom/idlharness.https.html?include=(Document|Window)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3f0245317c
Add shadowrootserializable attribute. r=dom-core,hsivonen
https://hg.mozilla.org/integration/autoland/rev/d07c0f070f10
Add serialization support for Declarative Shadow DOM. r=webidl,smaug

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fb3f0245317c
https://hg.mozilla.org/mozilla-central/rev/d07c0f070f10

Comment 10

[Hamish Willee]

FF128 MDN docs for this can be tracked in https://github.com/mdn/content/issues/34302 (just a release note and compatibility data required).