1890513 - Directly call native functions instead using InvokeNativeFunction

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[André Bargull [:anba]]

:jandem mentioned during code review that InvokeNativeFunction from bug 1889091 can be replaced with a direct call to the native C++ function.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1890513: Directly invoke variadic native functions. r=jandem!

CodeGenerator.cpp:
Split emitCallNative into two methods, so we can reuse it for emitApplyNative.
Also add some comments how NativeExitFrameLayout is constructed on the stack and
add an assertion that the native C++ function returned an object when constructing.
emitCallNative uses setupAlignedABICall, so we now need to align the Value
arguments, this happens through the new emitAlignStackForApplyNative method.

LIR-shared.h, Lowering.cpp:
The callee doesn't need to be stored which frees up one register, so we can
allocate an additional temp-register. This matches the approach taken for
LCallNative. The additional temp register is needed, because emitCallNative
requires four registers.

VMFunctions:

• Remove no longer used InvokeNativeFunction.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02ac150e8da3
Directly invoke variadic native functions. r=jandem

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02ac150e8da3