Closed Bug 1890526 Opened 2 years ago Closed 1 month ago

Doc generate warnings should be output by reviewbot or caught in a separate linter

Categories

(Developer Infrastructure :: Source Documentation, task)

Tracking

(firefox154 fixed)

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: sparky, Assigned: standard8)

References

Details

Attachments

(1 file)

There are a couple patches that landed recently (bug 1890496, and bug 1890498) which had issues in the sphinx doc generation. Based on the error messages that are displayed on failure in Treeherder, it can be very unclear that the patches in question caused a failure/issue. It would be good if these could be output by reviewbot during the review stage so we know the failures are related to the patch, and fix them prior to landing the patches.

Component: Firefox Source Docs: Content → Source Documentation

The attached patch exports a JSON list of errors when running the builder, but we'll also need code review bot updating to process the file.

Attachment #9536642 - Attachment description: Bug 1890526 - Export a JSON list of errors when running document upload, for code review bot to examine. → WIP: Bug 1890526 - Export a JSON list of errors when running document upload, for code review bot to examine.
Depends on: 2008962
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Attachment #9536642 - Attachment description: WIP: Bug 1890526 - Export a JSON list of errors when running document upload, for code review bot to examine. → Bug 1890526 - Export a JSON list of errors when running document upload, for code review bot to examine. r?ahal!
Pushed by mbanner@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0874c70bd8a3 https://hg.mozilla.org/integration/autoland/rev/24df4e54e656 Export a JSON list of errors when running document upload, for code review bot to examine. r=ahal
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Blocks: 2051591
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: