Closed
Bug 1890554
Opened 2 years ago
Closed 2 years ago
Use `ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST` flag in `nsHttpChannel::GetProxyDNSStrategy`
Categories
(Core :: Networking: Proxy, defect, P3)
Core
Networking: Proxy
Tracking
()
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: manuel, Assigned: sekim)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 external file)
We should just check the flag instead of duplicating the logic on whether the dns requests are handled by the proxy server (and not covering all cases like addons/pac scripts/...).
netwerk/protocol/http/nsHttpChannel.cpp#6373-6377
if (!StaticPrefs::network_proxy_socks_remote_dns()) {
if (type.EqualsLiteral("socks")) {
return DNS_PREFETCH_ORIGIN;
}
}
This is a simple change and could be considered to be marked as good-first-bug.
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [necko-triaged][necko-priority-new]
Updated•2 years ago
|
Blocks: necko-tech-debt
See Also: → 1890549
Whiteboard: [necko-triaged][necko-priority-new] → [necko-triaged]
Comment 1•2 years ago
|
||
The severity field is not set for this bug.
:edgul, could you have a look please?
For more information, please visit BugBot documentation.
Flags: needinfo?(edgul)
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → sekim
| Assignee | ||
Comment 2•2 years ago
|
||
| Assignee | ||
Updated•2 years ago
|
Status: NEW → ASSIGNED
Pushed by mbucher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac0998f3290d
Use ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST flag in nsHttpChannel::GetProxyDNSStrategy r=manuel,necko-reviewers,kershaw
| Assignee | ||
Updated•2 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment 4•2 years ago
|
||
| bugherder | ||
Updated•2 years ago
|
status-firefox128:
--- → fixed
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•