1890554 - Use `ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST` flag in `nsHttpChannel::GetProxyDNSStrategy`

Status: RESOLVED FIXED

(Core :: Networking: Proxy, defect, P3)

Description

[Manuel Bucher [:manuel]]

We should just check the flag instead of duplicating the logic on whether the dns requests are handled by the proxy server (and not covering all cases like addons/pac scripts/...).

netwerk/protocol/http/nsHttpChannel.cpp#6373-6377

if (!StaticPrefs::network_proxy_socks_remote_dns()) {
  if (type.EqualsLiteral("socks")) {
    return DNS_PREFETCH_ORIGIN;
  }
}

This is a simple change and could be considered to be marked as good-first-bug.

• flags need to be requested: https://searchfox.org/mozilla-central/rev/c09764753ea40725eb50decad2c51edecbd33308/netwerk/base/nsIProxyInfo.idl#40-45
• checked for this flag: https://searchfox.org/mozilla-central/rev/c09764753ea40725eb50decad2c51edecbd33308/netwerk/base/nsIProxyInfo.idl#100-105

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:edgul, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Sean Kim]

Attachment: Bug 1890554 - Use ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST flag in nsHttpChannel::GetProxyDNSStrategy r?manuel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac0998f3290d
Use ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST flag in nsHttpChannel::GetProxyDNSStrategy r=manuel,necko-reviewers,kershaw

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ac0998f3290d