1890629 - Update opus to new version fdb198e88660721e289df94c29e91f70caff787e from 2024-04-09 14:29:12

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 5 commits, including 3 new upstream commits I've never filed a bug on before. (They're the top 3.). Here are the overall diff statistics, and then the commit information.

---

media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
media/libopus/src/opus_private.h | 2 +-
media/libopus/src/repacketizer.c | 3 ++-
4 files changed, 6 insertions(+), 5 deletions(-)

---

fdb198e88660721e289df94c29e91f70caff787e by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opus/commit/fdb198e88660721e289df94c29e91f70caff787e
Authored: 2024-04-09 14:29:12 -0400
Committed: 2024-04-09 14:29:12 -0400

dump_data: remove all noise and output one signal

Now used for fargan instead of LPCNet

Files Modified:

• dnn/dump_data.c

---

4c5c498825f9442fb93f2ae902bcbc2e79e46072 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opus/commit/4c5c498825f9442fb93f2ae902bcbc2e79e46072
Authored: 2024-04-09 13:53:20 -0400
Committed: 2024-04-09 13:53:20 -0400

rename lpcnet_demo to fargan_demo

Files Modified:

• Makefile.am

Files Changed:

• R100 dnn/lpcnet_demo.c

---

504566f35a7fd4efc7a242bc7f699ef930b87f02 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opus/commit/504566f35a7fd4efc7a242bc7f699ef930b87f02
Authored: 2024-04-09 13:40:11 -0400
Committed: 2024-04-09 13:40:11 -0400

matching types

Files Modified:

• src/repacketizer.c

---

6ba257d8195039f25000b5b3a21a0a017ad70e8d by dvosully

https://gitlab.xiph.org/xiph/opus/commit/6ba257d8195039f25000b5b3a21a0a017ad70e8d
Authored: 2024-04-05 18:30:02 +1000
Committed: 2024-04-08 04:11:53 -0400

Change type of function parameter to match implementation

Signed-off-by: Jean-Marc Valin <[e-mail]>

Files Modified:

• src/opus_private.h

---

cbeebf007b8bed199212cb4e5da5ae79a5b24f97 by Malcolm Nixon

https://gitlab.xiph.org/xiph/opus/commit/cbeebf007b8bed199212cb4e5da5ae79a5b24f97
Authored: 2024-04-03 22:50:33 -0400
Committed: 2024-04-08 03:07:46 -0400

Update cmake to 3.16 and add OPUS_STATIC_RUNTIME option to control MSVC runtime library choice.

Signed-off-by: Jean-Marc Valin <[e-mail]>

Files Modified:

• .github/workflows/cmake.yml
• CMakeLists.txt

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=9bd220e2ba840ecadb6c0d30437307d313ae9b9b

Comment 3

[Update Bot]

Attachment: Bug 1890629 - Update opus to fdb198e88660721e289df94c29e91f70caff787e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2189c237df8
Update opus to fdb198e88660721e289df94c29e91f70caff787e r=kinetik

Comment 5

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• No tests were found for flavor 'plain' and the following manifest filters:
  skip_if, run_if, fail_if, subsuite(name=media), tags(['media-engine-compatible']), pathprefix(['dom/media/test/mochitest_background_video.toml', 'dom/media/test/mochitest_bugs.toml', 'dom/media/test/mochitest_eme.toml', 'dom/media/test/mochitest_stream.toml'])

  Make sure the test paths (if any) are spelt correctly and the corresponding
  --flavor and --subsuite are being used. See mach mochitest --help for a
  list of valid flavors.

  • 4 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (Egi4d5DHTdGQObSVZ4qAxw)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (fjw0g_CRS8axwt1XQjFaZw)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (OqPgRrwIRFKeDqPE_nykHg)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (R4TCJAZWTVCBQs802l82eg)

Needs Investigation (Possible Intermittents):

• test-android-em-7.0-x86_64-qr/debug-isolated-process-geckoview-gtest-1proc - 1 of 4 failed on the same (retriggered) task (failed: DoR3f4-ZQwqUWZ0x5Trr-g)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libopus/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 6

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Comment 7

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/a2189c237df8