1890706 - GeolocationCoordinates and GeolocationPosition should expose a Default .toJSON() method

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement)

Description

[marcos]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15

Steps to reproduce:

Check the GeolcationCoordinate prototype for a .toJSON() method.

Actual results:

There is no such method.

Expected results:

When a position object is successfully acquired, it should be possible to call .toJSON() on its .coords attribute.

Comment 1

[marcos]

This is spec change proposal:
https://github.com/w3c/geolocation-api/pull/147

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[marcos]

WE updated the spec proposal to add toJSON() on both GeolocationPosition and GeolocationCoordinates.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Chrome and Safari now support this, as of this WebKit commit: https://github.com/WebKit/WebKit/commit/0160ba82ea224867551f48009bf73f578536c27d

Comment 5

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

I 👍-ed the PR so I guess I should implement it 🙂

Comment 6

[marcos]

That's the spirit! 🥰 Looking forward to feature parity on this.

On a more serious note, this will be hugely helpful to getting the spec back to REC, so will track this for when it's done.

Comment 7

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1890706 - Implement default toJSON for GeolocationCoordinates and GeolocationPosition and add a web platform test; r?saschanaz

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d97cf89b399
Implement default toJSON for GeolocationCoordinates and GeolocationPosition and add a web platform test; r=saschanaz,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/334970d67bba
1902720: apply code formatting via Lando

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46773 for changes under testing/web-platform/tests

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ae7a50367303bcdbabd20edbf8d7113a8abc04c2

Push with failures

Failure log ->

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b073db6e420b
Implement default toJSON for GeolocationCoordinates and GeolocationPosition and add a web platform test; r=saschanaz,webidl,smaug

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b073db6e420b

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Hamish Willee]

FF129 Docs work for this can be tracked in https://github.com/mdn/content/issues/34841