189073 - Changing several bugs at once offer inconsistent resolution/status options compared with bug edit/view page

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Raphael Bossek]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.2.1) Gecko/20021130

1. Multiple RESOLVED/*-only bugs

While changing several RESOLVED/*-only bugs at once you get *only* this
offer to change the resolution/status:
( ) Accept bugs
( ) Reopen bugs
( ) Mark bugs as VERIFIED

This is not the same as edit a single bug.
While edit a single RESOLVED/* bug you have following options to change the
resolution/status of this bug:
( ) Reopen bug
( ) Mark bug as VERIFIED
( ) Mark bug as CLOSED

This should be the same for changing several bugs at once. You need also
the possibility to change several RESOLVED/* bugs to CLOSED/* bugs.

Rule 1: If only RESOLVED/* or VERIFIED/* bugs appear you have the possibility
to change their resolution to CLOSED without changing the status.
Rule 2a: It is not possible to "Accept bugs" while changing several bugs
at once and at least one is RESOLVED/*.

2. Multiple VERIFIED/*-only bugs

While changing serveral VERIFIED/*-only bugs at once you get *only* this
offer to change the resolution/status:
( ) Accept bugs
( ) Reopen bugs
( ) Mark bugs as CLOSED

If a single VERIFIED/* bug is edited *only* following options are offered to
change the resolution/status:
( ) Reopen bug
( ) Mark bug as CLOSED

Rule 2b: It is not possible to "Accept bugs" while changing several bugs
at once and at least one is VERIFIED/*.

3. Multiple CLOSED/*-only bugs

While changing serveral CLOSED/*-only bugs at once you get *only* this
offer to change the resolution/status:
( ) Accept bugs
( ) Reopen bugs

If a single CLOSED/* bug is edited *only* following options are offered to
change the resolution/status:
( ) Reopen bug

Rule 2c: It is not possible to "Accept bugs" while changing several bugs
at once and at least one is CLOSED/*.

Reproducible: Always

Steps to Reproduce:
1. Query where only resolution is set to RESOLVED or VERIFIED or CLOSED
2. Click on "Change several bugs at once"
3. Compare the option fields with the option filds with one of the displeyed
bugs
4. See the inconsistency mentioned.

Comment 1

[Raphael Bossek]

Attachment: Fixes the inconstencies with resolution/status

This patch fixes the mentioned inconsistencies with the
resolution/state while changing multiple bugs at once.
The one and only affected file is
template/en/default/list/edit-multiple.html.tmpl

Comment 2

[Max Kanat-Alexander]

Behavior 1
----------
I can confirm behavior 1 on today's cvs-tip of 2.17.6. However, you CAN set
VERIFED bugs to CLOSED. Still, the behavior should be consistent between the two
templates.

In addition, now you can re-assign RESOLVED bugs in the mass-change, but you
can't re-assign them individually.

Behavior 2
----------
You can "Accept" a VERIFIED bug, but nothing happens. (That is, email is sent,
but there is no status change.) "Accept" should be removed from mass-change GUI.

Behavior 3
----------
Same as #2

This seems like a simple fix. The patch attached looks good on a quick glance,
but may have bit-rotted.

-M

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Allowing Accept only if all bugs are open

Closing resolved bugs WORKSFORME since bug 239826, so restricting Accept is all
what needs to be done.

Comment 4

[Christian Reis]

Comment on attachment 158087 [details] [diff] [review]
Allowing Accept only if all bugs are open

Tested, looks good.

Comment 5

[Christian Reis]

(In reply to comment #2)
> In addition, now you can re-assign RESOLVED bugs in the mass-change, but you
> can't re-assign them individually.

Can someone please file an additional bug to investigate whether this is
intentional or not? I'm not sure it's not actually a good thing to allow this
everywhere -- having to reopen a bug and then reassign seems a bit obnoxious.

Comment 6

[Dave Miller [:justdave]]

(In reply to comment #5)
> (In reply to comment #2)
> > In addition, now you can re-assign RESOLVED bugs in the mass-change, but you
> > can't re-assign them individually.
> 
> Can someone please file an additional bug to investigate whether this is
> intentional or not? I'm not sure it's not actually a good thing to allow this
> everywhere -- having to reopen a bug and then reassign seems a bit obnoxious.

It was intentional on mass-change.  We needed it when moving bugs out of
Webtools into Bugzilla during the product move.  I think it only still doesn't
work on show_bug for historical reasons.  I don't know any reason why it shouldn't.

Comment 7

[Vlad Dascalu]

Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v
 <--  edit-multiple.html.tmpl
new revision: 1.20; previous revision: 1.19
done

Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v
 <--  edit-multiple.html.tmpl
new revision: 1.17.2.2; previous revision: 1.17.2.1
done

Comment 8

[Vlad Dascalu]

Forgot to mention in the cvs log the author (patch was made by Marc Schumann
<[e-mail]>).