1890761 - Switch to tab option is present with only one tab open

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: issue

Notes

• Please refer to the following screen recording for more details.

Found in

• Nightly 126.0a1;

Affected versions

• Nightly 126.0a1;
• Firefox 125.0;

Tested platforms

• Windows 10;
• macOS 12;
• Ubuntu 22;

Affected platforms

• Windows 10;
• macOS 12;
• Ubuntu 22;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Firefox
2. Open a topsite( e.g Facebook).
3. In the same tab, focus the address bar.

Expected result

• Switch to tab option shouldn’t appear at all in the address bar.

Actual result

• Switch to tab option is present in the address bar.

Regression range

• Doesn’t seem to be a regression as it is reproducible as far back as Firefox 73.0a1.

Comment 1

[Marco Bonardo [:mak]]

[UrlbarProviderTopSites
(https://searchfox.org/mozilla-central/rev/d23849dd6d83edbe681d3b4828700256ea34a654/browser/components/urlbar/UrlbarProviderTopSites.sys.mjs) is not checking queryContext.currentPage to avoid returning switch to the current tab, differently from UrlbarProviderPlaces that has been already fixed in the past

Comment 2

[Yazan Al Macki [:yazan]]

Attachment: Bug 1890761 - Checking currentPage and userContextId to prevent Switch To Tab suggestion from showing for current tab and/or current container based on pref. r?mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a3ccf1d2b7a
Checking currentPage and userContextId to prevent Switch To Tab suggestion from showing for current tab and/or current container based on pref. r=mak

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7a3ccf1d2b7a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2024-04-10 Nightly build on Windows 10.
Verified as fixed on Firefox 128.0b1 and Firefox Nightly 129.0a1 on Windows 10, Ubuntu 22, macOS 14.