1890771 - Test JSON.parse with source edge cases

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Bryan Thrall [:bthrall]]

We want to make sure JSON.parse with source feature works at least in the following situations:

• Inside of Workers
• Interactions across multiple compartments (CCW, etc.)
• OOM behavior
• Exotic web platform objects (WindowProxy, cross-origin, etc.)
• X-rays

So we should add automated tests to verify that it does function as expected.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Fix JSON.parse with source OOM, add tests r=mgaudet

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Check that errors come from the correct realm and RawJSONObjects can be used as prototypes r=mgaudet

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Test and fix JSON.isRawJSON() when handling CrossCompartmentWrappers r=mgaudet

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Correctly set pref when custom shell flag is not there r=mgaudet

When --setpref is used, but --enable-json-parse-with-source is not, the custom
shell flag handling was overriding the --setpref value.

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Check that JSON.parse with source features work in web workers r=mgaudet

Note the raw field is parsed as a number because JSON.stringify() serializes
RawJSONObject("4.32") as a number ('4.32') rather than a string ('"4.32"').

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Improve failure output for JSON.parse tests and group tests r=mgaudet

Using an IIFE lets me group the tests and name the group.

Comment 7

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Unwrap RawJSONObject CCW inside JSON.stringify r=mgaudet

Comment 8

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Check that WindowProxy gets JSON.rawJSON(), JSON.isRawJSON() and Location is handled correctly r=mgaudet

Comment 9

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Check JSON.parse with source handling of Xrays r=mgaudet

How the rawJSON field should be handled isn't clear to me yet.

Changing set_spidermonkey_pref to always is necessary for xpcshell to get the
pref value correctly. This is because xpcshell sets the prefs from
xpcshell.toml after the JS engine is initialized (via user.js);
experimental.json_parse_with_source is still false at that point.

Comment 10

[Bryan Thrall [:bthrall]]

Attachment: Bug 1890771 - Make rawJSON member enumerable r=mgaudet

It should be, according to

https://tc39.es/ecma262/#sec-createdatapropertyorthrow

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/231a98c0f826
Fix JSON.parse with source OOM, add tests r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e87cbf65f386
Check that errors come from the correct realm and RawJSONObjects can be used as prototypes r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1566570e97e7
Test and fix JSON.isRawJSON() when handling CrossCompartmentWrappers r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/90aceddc9988
Correctly set pref when custom shell flag is not there r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/fd197b7a873e
Check that JSON.parse with source features work in web workers r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/95bf36cdb7c5
Improve failure output for JSON.parse tests and group tests r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e4a0f6fcac10
Unwrap RawJSONObject CCW inside JSON.stringify r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/70a20173bda0
Check JSON.parse with source handling of Xrays r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7a1ccaa09fc0
Make rawJSON member enumerable r=mgaudet

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest plain failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/d63641241a5df86293ce726fa7a35787a6df8b35

Push with failures

Failure log -> The 'prefs' key must be set in the DEFAULT section of a manifest. Fix the following manifests: js/xpconnect/tests/mochitest/mochitest.toml

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/318f2311a5e0
Fix JSON.parse with source OOM, add tests r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/30bd191dca7d
Check that errors come from the correct realm and RawJSONObjects can be used as prototypes r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/12b1739f207e
Test and fix JSON.isRawJSON() when handling CrossCompartmentWrappers r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/29bae6b779a4
Correctly set pref when custom shell flag is not there r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/27bcb460dac2
Check that JSON.parse with source features work in web workers r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/57c453f97bcc
Improve failure output for JSON.parse tests and group tests r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/2635be086cf2
Unwrap RawJSONObject CCW inside JSON.stringify r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7d755d87bc7d
Check JSON.parse with source handling of Xrays r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/8405145a8468
Make rawJSON member enumerable r=mgaudet

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/318f2311a5e0
https://hg.mozilla.org/mozilla-central/rev/30bd191dca7d
https://hg.mozilla.org/mozilla-central/rev/12b1739f207e
https://hg.mozilla.org/mozilla-central/rev/29bae6b779a4
https://hg.mozilla.org/mozilla-central/rev/27bcb460dac2
https://hg.mozilla.org/mozilla-central/rev/57c453f97bcc
https://hg.mozilla.org/mozilla-central/rev/2635be086cf2
https://hg.mozilla.org/mozilla-central/rev/7d755d87bc7d
https://hg.mozilla.org/mozilla-central/rev/8405145a8468