1890795 - Count number of trust objects in db

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P3)

Comment 1

[Nuohan Li]

Attachment: Bug 1890795 - Count number of trust objects in db r=jschanck

Comment 2

[Nuohan Li]

Attachment: Bug 1890795 - Count number of trust objects in db, r=jschanck

Comment 3

[Nuohan Li]

Attachment: bug1890795-data-review.md

Comment 4

[Nuohan Li]

We would like to know if there are a lot of users who actually manage their own certificates. If there isn't, then perhaps there is no need to query cert9.db, which could speed up Firefox loading speed.

Comment 5

[Nuohan Li]

This telemetry's expiry is set to 132 in metric.yaml

Comment 6

[Roger Yang [:royang]]

Comment on attachment 9397227 [details]
bug1890795-data-review.md

DATA COLLECTION REVIEW RESPONSE:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. These collections are Glean. The opt-out can be found in the product's preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

[e-mail] will be responsible for the collection.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

5. Is the data collection request for default-on or default-off?

Default on for all channels.

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result: data-review+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e136a9921c4b
Count number of trust objects in db, r=jschanck,firefox-desktop-core-reviewers

Comment 8

[Iulian Moraru]

Backed out for causing mass build bustages.

• Push with failures

• Failure log

• Backout link

[task 2024-04-22T19:43:46.740Z] 19:43:46     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/library/build'
[task 2024-04-22T19:43:46.743Z] 19:43:46     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -isysroot /builds/worker/fetches/MacOSX14.4.sdk -mmacosx-version-min=10.15 -stdlib=libc++ --target=x86_64-apple-darwin -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror  -o XUL -Wl,-filelist,/builds/worker/workspace/obj-build/toolkit/library/build/XUL.list    -fuse-ld=lld -fstack-protector-strong '-Wl,-U,_OBJC_CLASS_$_NSTouchBar' '-Wl,-U,_OBJC_CLASS_$_NSSharingServicePickerTouchBarItem' '-Wl,-U,_OBJC_METACLASS_$_NSTouchBar' '-Wl,-U,_OBJC_CLASS_$_NSCustomTouchBarItem' '-Wl,-U,_OBJC_CLASS_$_NSPopoverTouchBarItem' -lresolv -Wl,-rpath,@executable_path/../Frameworks/ChannelPrefs.framework -Wl,-dead_strip  ../../../js/src/build/libjs_static.a ../../../build/pure_virtual/libpure_virtual.a /builds/worker/workspace/obj-build/x86_64-apple-darwin/debug/libgkrust.a ../../../security/libnss3.dylib ../../../config/external/gkcodecs/libgkcodecs.dylib ../../../config/external/lgpllibs/liblgpllibs.dylib ../../mozapps/macos-frameworks/ChannelPrefs/ChannelPrefs ../../../mozglue/build/libmozglue.dylib -Wl,-exported_symbols_list,XUL.symbols -dynamiclib -install_name @rpath/XUL -compatibility_version 1 -current_version 1  -lresolv -lbsm -framework IOSurface -framework IOKit -framework AudioToolbox -framework CoreMedia -framework VideoToolbox -Wl,-U,_VTRegisterSupplementalVideoDecoderIfAvailable -Wl,-U,_VTIsHardwareDecodeSupported -framework AuthenticationServices -framework Vision -framework LocalAuthentication -framework Security -lm -framework Foundation -framework CoreFoundation -framework CoreLocation -framework QuartzCore -framework Carbon -framework CoreAudio -framework CoreVideo -framework AudioUnit -framework AddressBook -framework OpenGL -framework ServiceManagement -framework CoreServices -framework ApplicationServices -framework AppKit -framework CoreMIDI -framework SystemConfiguration -framework AVFoundation -F/builds/worker/fetches/MacOSX14.4.sdk/System/Library/PrivateFrameworks -framework CoreUI -framework CoreSymbolication -lcups -weak_framework Metal -weak_framework MediaPlayer
[task 2024-04-22T19:43:46.743Z] 19:43:46    ERROR -  ld64.lld: error: undefined symbol: PK11_DestroyGenericObjects
[task 2024-04-22T19:43:46.743Z] 19:43:46     INFO -  >>> referenced by nsNSSCertificateDB.cpp:69 (/builds/worker/checkouts/gecko/security/manager/ssl/nsNSSCertificateDB.cpp:69)
[task 2024-04-22T19:43:46.744Z] 19:43:46     INFO -  >>>               ../../../security/manager/ssl/Unified_cpp_security_manager_ssl2.o:(symbol nsNSSCertificateDB::CountTrustObjects(unsigned int*)+0x54)
[task 2024-04-22T19:43:46.744Z] 19:43:46     INFO -  >>> did you mean: PK11_DestroyGenericObject
[task 2024-04-22T19:43:46.744Z] 19:43:46     INFO -  >>> defined in: ../../../security/libnss3.dylib
[task 2024-04-22T19:43:46.744Z] 19:43:46    ERROR -  ld64.lld: error: undefined symbol: PK11_GetNextGenericObject
[task 2024-04-22T19:43:46.745Z] 19:43:46     INFO -  >>> referenced by nsNSSCertificateDB.cpp:66 (/builds/worker/checkouts/gecko/security/manager/ssl/nsNSSCertificateDB.cpp:66)
[task 2024-04-22T19:43:46.745Z] 19:43:46     INFO -  >>>               ../../../security/manager/ssl/Unified_cpp_security_manager_ssl2.o:(symbol nsNSSCertificateDB::CountTrustObjects(unsigned int*)+0x47)
[task 2024-04-22T19:43:46.745Z] 19:43:46    ERROR -  ld64.lld: error: undefined symbol: PK11_FindGenericObjects
[task 2024-04-22T19:43:46.745Z] 19:43:46     INFO -  >>> referenced by nsNSSCertificateDB.cpp:63 (/builds/worker/checkouts/gecko/security/manager/ssl/nsNSSCertificateDB.cpp:63)
[task 2024-04-22T19:43:46.746Z] 19:43:46     INFO -  >>>               ../../../security/manager/ssl/Unified_cpp_security_manager_ssl2.o:(symbol nsNSSCertificateDB::CountTrustObjects(unsigned int*)+0x1f)
[task 2024-04-22T19:43:46.746Z] 19:43:46    ERROR -  clang++: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2024-04-22T19:43:46.746Z] 19:43:46    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:541: XUL] Error 1
[task 2024-04-22T19:43:46.747Z] 19:43:46     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/build'
[task 2024-04-22T19:43:46.747Z] 19:43:46     INFO -  gmake[4]: Target 'target' not remade because of errors.
[task 2024-04-22T19:43:46.747Z] 19:43:46     INFO -  gmake[4]: Target 'target' not remade because of errors.
[task 2024-04-22T19:43:46.748Z] 19:43:46    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/build/target] Error 2
[task 2024-04-22T19:43:46.749Z] 19:43:46     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/mfbt/tests'

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b23075eff6f
Count number of trust objects in db, r=jschanck,firefox-desktop-core-reviewers

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5b23075eff6f