1890890 - icon_font_allowlist: request to add iconfont "Google Symbols" used in new Google apps

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Ronan Jouchet [:ronjouch]]

Attachment: firefox-iconfontallowlist_add-googlesymbols.png

This is a follow-up to #1521352, comment 33 where :dholbert asks:

if you notice any sites that are still broken [...], please file bugs (ideally as dependencies of bug 1363454) so we can add any other font names that were missed

Yes I'd like to request adding iconfont Google Symbols to the allowlist.

See attached screenshot, captured with a fresh new profile with Firefox 125.0b9 on Linux (via Arch pkg firefox-developer-edition):

• Google AI Studio has fully-broken icons if using browser.display.use_document_fonts = 0 ...
• And adding , Google Symbols at the end of browser.display.use_document_fonts.icon_font_allowlist fully fixes fonts

Comment 1

[Pierre Ossman]

Google Meet also uses this font for some UI elements.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1890890 - Add Google Symbols and FontAwesome to the default icon_font_allowlist. r=#layout

Comment 3

[Ronan Jouchet [:ronjouch]]

As I see this is assigned, sharing my current extensions of the allowlist:

, FontAwesome, Google Symbols, RevenuQuebecIcons, ETmodules

• Google Symbols was the reason for this bug, see Comment 1 for usage
• FontAwesome used in a lot of places
• RevenuQuebecIcons used by https://www.revenuquebec.ca/
• ETmodules is the The Elegant Icon Font, sorry I forgot where it's used

Comment 4

[Jonathan Kew [:jfkthame]]

I've gone ahead and added FontAwesome to the current patch here, as I know it's widely used - thanks. I'm not familiar with ETmodules, but if it's also quite widespread, we could consider including it as a followup.

For RevenuQuebecIcons: I'd be more hesitant to add what looks like a site-specific custom font to the default list; that seems like a path towards a never-ending stream of obscure single-purpose additions.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54d0ef0b6e0c
Add Google Symbols and FontAwesome to the default icon_font_allowlist. r=layout-reviewers,emilio

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/54d0ef0b6e0c