1890927 - PR_GetUniqueIdentity asserts on the 32767th call

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Lars Eggert [:lars]]

Attachment: prlayer.c.diff

Reported in https://github.com/mozilla/neqo/issues/1449, but this is an NSPR limitation/bug.

PRDescIdentity is a PRIntn typedef, which on most (all?) platforms now is at least four bytes long. The failing assert in PR_GetUniqueIdentity() assumes a (fixed) two-byte length, however.

Patch that changes this assert to be length-aware is attached.

Comment 1

[Lars Eggert [:lars]]

Attachment: prlayer.c.diff

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Lars Eggert [:lars]]

I guess the fix for this didn't make it into the recent NSPR release? Is there a timeline for landing this?

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9396164 [details] [diff] [review]
prlayer.c.diff

Thank you Lars, LGTM, and sorry it took so long to find time for it.

r=kaie

Comment 5

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nspr/rev/2c58aefdf89944d50e9577d6a00e1f2ba61b8f58

Comment 6

[Kai Engert [:KaiE:]]

There's a problem with the commit, reopening.

https://treeherder.mozilla.org/jobs?repo=nss&selectedTaskRun=Eu6_KVZfTsa53XgIShg3kw.0

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../../../pr/src/io/prlayer.c:565:3 in

Comment 7

[Kai Engert [:KaiE:]]

It might be necessary to explicitly set the type of "1", to ensure the left shift is considered acceptable for the type.

Comment 8

[Kai Engert [:KaiE:]]

I'll attach an attempted fix and start a try run.

Comment 9

[Kai Engert [:KaiE:]]

Attachment: Bug 1890927 - Follow-up to fix a report from UndefinedBehaviorSanitizer. r=leggert

Comment 10

[Kai Engert [:KaiE:]]

Patch works, will request review.
https://treeherder.mozilla.org/jobs?repo=nss-try&revision=5e81b47ab8360e94798b9c60fbe79e02ba96b60c

Comment 11

[Kai Engert [:KaiE:]]

pushed with rs=bustage
https://hg.mozilla.org/projects/nspr/rev/312d29bc142f57cca74261be4f05dc863be35a6f