189094 - [FIX]OS X and OS9, helper app dlg: OS-associated app is listed in "Open with" textfield

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[sairuh (rarely reading bugmail)]

found using 2003.01.13.08 comm trunk (cfm) build on Mac OS X 10.2.3. rather than
having a radiobutton selected for "Open it with the default application
(appname)", that radiobutton is missing, and there are only 2 radiobuttons
available (saving to disk selected, too):

() Open it with [OS-associated application fullpath displayed]
(*) Save it to disk

screenshot coming up.

Comment 1

[sairuh (rarely reading bugmail)]

Attachment: helper application dialog on OS X

i'll also double-check to see what this is like using mach-o/mozilla.

Comment 2

[sairuh (rarely reading bugmail)]

same results with mach-o/moz (2003.01.13.07), the only difference being how the
path was displayed:

CFM:      maggie:Applications:Preview.app

mach-o:   /Applications/Preview.app

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: something like this?

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is a problem on OS9 too, btw.. (or should be)

Comment 5

[Simon Fraser [no longer active]]

Can you say a little about what the patch is doing?

Comment 6

[Philip K. Warren]

Comment on attachment 111555 [details] [diff] [review]
something like this?

Looks good but I would like to hear back test results from a Mac build - I
don't have a Mac machine to test.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Sure thing.  Since bug 86640 landed a MIMEInfo has two apps associated with it
-- the "default OS app" and the "user-selected app" (the latter is null if it's
the same as the OS app).  The code that reads from IC is setting the
"user-selected app"; it should be setting the "default OS app".  The benefit is
that in preferences we just save a flag that says "use the default OS app" and
look it up every time we need it instead of saving a ref to the actual app and
flailing if the OS setup changes.

I had cls test this and he says it works like it's supposed to.

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 111555 [details] [diff] [review]
something like this?

Thanks (every patch should have such a description!).

NS_ConvertASCIItoUCS2 look evil: I think that's where (tm) signs may get
whacked. Ideally, it needs to use the system charset to convert from IC's char*
(the IC api doesn't specify what charset its data are stored in) to Unicode. Or
maybe one of the nsIFile native path/unicode path thingies.

Comment 9

[Boris Zbarsky [:bzbarsky]]

fixed.  Bug 189108 filed on the charset issue.

Comment 10

[Chris Petersen]

Yes, I now get three buttons in this dialog: 
Open with Default application, Open it with: , and Save it to Disk.

Verified in the 2003-01-15-08 CFM trunk under 10.2.3. Thanks, Sarah !