Closed
Bug 189094
Opened 22 years ago
Closed 22 years ago
[FIX]OS X and OS9, helper app dlg: OS-associated app is listed in "Open with" textfield
Categories
(Core Graveyard :: File Handling, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.3beta
People
(Reporter: bugzilla, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
19.32 KB,
image/png
|
Details | |
1.47 KB,
patch
|
pkwarren
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
found using 2003.01.13.08 comm trunk (cfm) build on Mac OS X 10.2.3. rather than having a radiobutton selected for "Open it with the default application (appname)", that radiobutton is missing, and there are only 2 radiobuttons available (saving to disk selected, too): () Open it with [OS-associated application fullpath displayed] (*) Save it to disk screenshot coming up.
Reporter | ||
Comment 1•22 years ago
|
||
i'll also double-check to see what this is like using mach-o/mozilla.
Reporter | ||
Comment 2•22 years ago
|
||
same results with mach-o/moz (2003.01.13.07), the only difference being how the path was displayed: CFM: maggie:Applications:Preview.app mach-o: /Applications/Preview.app
Assignee | ||
Comment 3•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #111555 -
Flags: superreview?(sfraser)
Attachment #111555 -
Flags: review?(pkw)
Assignee | ||
Comment 4•22 years ago
|
||
This is a problem on OS9 too, btw.. (or should be)
Severity: normal → major
Status: NEW → ASSIGNED
Flags: blocking1.3b?
Priority: -- → P1
Summary: OS X, helper app dlg: OS-associated app is listed in "Open with" textfield → [FIX]OS X and OS9, helper app dlg: OS-associated app is listed in "Open with" textfield
Target Milestone: --- → mozilla1.3beta
Comment 5•22 years ago
|
||
Can you say a little about what the patch is doing?
Comment 6•22 years ago
|
||
Comment on attachment 111555 [details] [diff] [review] something like this? Looks good but I would like to hear back test results from a Mac build - I don't have a Mac machine to test.
Attachment #111555 -
Flags: review?(pkw) → review+
Assignee | ||
Comment 7•22 years ago
|
||
Sure thing. Since bug 86640 landed a MIMEInfo has two apps associated with it -- the "default OS app" and the "user-selected app" (the latter is null if it's the same as the OS app). The code that reads from IC is setting the "user-selected app"; it should be setting the "default OS app". The benefit is that in preferences we just save a flag that says "use the default OS app" and look it up every time we need it instead of saving a ref to the actual app and flailing if the OS setup changes. I had cls test this and he says it works like it's supposed to.
Comment 8•22 years ago
|
||
Comment on attachment 111555 [details] [diff] [review] something like this? Thanks (every patch should have such a description!). NS_ConvertASCIItoUCS2 look evil: I think that's where (tm) signs may get whacked. Ideally, it needs to use the system charset to convert from IC's char* (the IC api doesn't specify what charset its data are stored in) to Unicode. Or maybe one of the nsIFile native path/unicode path thingies.
Attachment #111555 -
Flags: superreview?(sfraser) → superreview+
Assignee | ||
Comment 9•22 years ago
|
||
fixed. Bug 189108 filed on the charset issue.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 10•22 years ago
|
||
Yes, I now get three buttons in this dialog: Open with Default application, Open it with: , and Save it to Disk. Verified in the 2003-01-15-08 CFM trunk under 10.2.3. Thanks, Sarah !
Status: RESOLVED → VERIFIED
Updated•22 years ago
|
Flags: blocking1.3b?
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•