1891028 - Opening a new browser window should potentially wait for the "browser-delayed-startup-finished" notification

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we only wait for this notification for the initial window, but not when using any WebDriver BiDi or Marionette commands to open a new context. As such our commands may return too early and causing issues. See bug 1837949 comment 5.

I would wait with any work here until bug 1837949 has been fixed to not influence test scenarios and make it harder to see.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Actually this might cause issues when interacting with a window that is not ready yet and certain components like safe browsing, or the blocklist not yet working. See bug 1975796 comment 5 as example.

I'll try to find some time this week to come up with a patch.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It would be good to only have to modify the TabManager and WindowManager and not as well Marionette. As such I've checked if the patch on bug 1795841 now works and indeed with the newer Linux versions it seems to be fine now. So lets wait until this landed.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Actually this observer notification is only sent when opening a new browser window but not for new tabs. So we are not blocked on a solution for bug 1795841.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1891028 - [remote] Wait for "browser-delayed-startup-finished" when opening a new browser window.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b20d5047f418
https://hg.mozilla.org/integration/autoland/rev/de0ac808a5aa
[remote] Wait for "browser-delayed-startup-finished" when opening a new browser window. r=Sasha

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be62884d661c
https://hg.mozilla.org/integration/autoland/rev/0d0cb00a3838
Revert "Bug 1891028 - [remote] Wait for "browser-delayed-startup-finished" when opening a new browser window. r=Sasha" for causing wpt failures.

Comment 8

[agoloman]

Backed out for causing wpt failures.

• Backout link
• Push with failures
• Failure Log

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All these failures are on Android where we actually do not have to wait for this observer notification because only a single window exists anyway and we check the status early when Marionette / Remote Agent starts-up. Also there is no gBrowserInit object available for Thunderbird and SeaMonkey so we should limit the check for window.gBrowserInit.delayedStartupFinished to just Firefox for now.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a41387427e9
https://hg.mozilla.org/integration/autoland/rev/bbfd8b52707a
[remote] Wait for "browser-delayed-startup-finished" when opening a new browser window. r=Sasha

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bbfd8b52707a