189110 - can't compile 1.2.1 source with following settings of configure

Status: VERIFIED DUPLICATE of bug 178987

(SeaMonkey :: Build Config, defect)

Description

[Misan Cijoml]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; cs-CZ; rv:1.2.1) Gecko/20021224
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; cs-CZ; rv:1.2.1) Gecko/20021224

can't compile mozilla with:

./configure --with-x --disable-logging --enable-reorder --enable-timeline
--enable-xterm-updates --enable-optimize=-O3 --enable-crypto --disable-debug
--disable-tests --enable-toolkit-qt

Reproducible: Always

Steps to Reproduce:
1.select configure
2.make all
3.can't compile one file when 
--enable-toolkit-qt is enabled - tested with standart devel libs under Debian
3.0 woody 
Actual Results:  
can't compile

Expected Results:  
rewrite it

Comment 1

[R.K.Aa.]

--enable-toolkit-qt barely builds, and not out of the box. Details in bug 178987

*** This bug has been marked as a duplicate of 178987 ***

Comment 2

[Roland Mainz]

R.K.Aa wrote:
> --enable-toolkit-qt barely builds, and not out of the box. Details in bug 
> 178987

Qt toolkit now works mainly again, but "--enable-toolkit-qt" is wrong - please
use --enable-default-toolkit=qt instead.

Comment 3

[R.K.Aa.]

Reopening.
http://webtools.mozilla.org/build/config.cgi states the parameter is
--enable-toolkit-qt

Comment 4

[R.K.Aa.]

and reassign

Comment 5

[Roland Mainz]

R.K.Aa wrote:
> Reopening.
> http://webtools.mozilla.org/build/config.cgi states the parameter is
> --enable-toolkit-qt

Read http://webtools.mozilla.org/build/config.cgi again, please. In the same
table cell is "--enable-default-toolkit=".
--enable-toolkit-qt/--enable-toolkit-xlib/--enable-toolkit-gtk are for builing
multiple toolkits in the same build.

Comment 6

[Misan Cijoml]

I read configure script and there is written:

ac_help="$ac_help
  --enable-toolkit-gtk    Enable GTK+ toolkit support "
ac_help="$ac_help
  --enable-toolkit-xlib   Enable xlib toolkit support "
ac_help="$ac_help
  --enable-toolkit-qt     Enable Qt Toolkit support "

co I choosed this option - these enables should be removed  from code then...

Comment 7

[Misan Cijoml]

I remembered to tell, that I wanted to build mozilla with GTK and qt in the same
build...

Comment 8

[Roland Mainz]

Misan Cijoml wrote:
> these enables should be removed  from code then...

Erm... please no... they are usefull... but we could adjust the "usage" help
strings for this switches a little bit to make it clearer what they mean...

Comment 9

[Roland Mainz]

Misan Cijoml wrote:
> I remembered to tell, that I wanted to build mozilla with GTK and qt in the 
> same build...

Building works, but only one toolkit (that one chosen by
--enable-default-toolkit= will work, dynamic switching has not been implemeted
yet, that's bug 184684 ("Add command-line switch to start up using specific
toolkit (e.g. gtk, qt, photon, xlib, etc.)")).

Comment 10

[Misan Cijoml]

Nice, but when I run configure only with: --with-x --disable-logging
--enable-reorder --enable-timeline
--enable-xterm-updates --enable-optimize=-O3 --enable-crypto --disable-debug
--disable-test

and configure script find both libs - GTK and qt, it starts compile both
together and not select GTK or qt as primary

default should be --enable-default-toolkit=gtk then...am I right?

Comment 11

[Roland Mainz]

Default toolkit is always "gtk" unless explicitly overridden by
--enable-default-toolkit= ...

Comment 12

[Misan Cijoml]

no, it isn't - I tried it now and it compiled both of them and finished with
error in compilation...

Comment 13

[Roland Mainz]

BTW: Looking at the "summary" - you are using the 1.2.1 release tarball, right ?
The Qt fixes were done after that release - using a "trunk" source tarball or
pulling from CVS should work...

Comment 14

[hacker formerly known as [e-mail]]

Why was this bug reopened?  It's clearly a dupe of bug 178987.  Qt support for
1.2.x is broken and I doubt that any of the changes will be backported.  If you
want qt support (which is still kinda broken), you'll have to use a trunk build.
Building with multiple toolkits was supported a one point then it was broken so
that our unused splash screen implementation didn't cause a massive spike in the
startup time.  Consider it unsupported until further notice.

*** This bug has been marked as a duplicate of 178987 ***

Comment 15

[Roland Mainz]

cls:
> If you want qt support (which is still kinda broken),
>                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This isn't true anymore. Qt toolkit works - the only remaining big issue is that
menus do not work (yet) - timeless is looking at that...

Comment 16

[hacker formerly known as [e-mail]]

> > If you want qt support (which is still kinda broken),
> >                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> This isn't true anymore. Qt toolkit works - the only remaining big issue is that
> menus do not work (yet) - timeless is looking at that...

HELLO!  Menus are a significant part of the application.   Bookmarks didn't work
when I tried them this morning either.  That falls under "still kinda broken". 
Would you prefer "not on par with either xlib or gtk support"?  There's more to
"support" than getting the code to compile.

Comment 17

[Tracy Walker [:tracy]]

verified