1891140 - Hit MOZ_CRASH(Tried to insert buffer already tracked) at /third_party/rust/wgpu-core/src/track/buffer.rs:402

Status: VERIFIED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 008989a6a743 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 008989a6a743 --debug --fuzzing  -n firefox
$ python -m grizzly.replay.bugzilla ./firefox/firefox <bugid>

Hit MOZ_CRASH(Tried to insert buffer already tracked) at /third_party/rust/wgpu-core/src/track/buffer.rs:402

    ==27516==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x74564496a2f5 bp 0x7455bc76e300 sp 0x7455bc76e2f0 T27597)
    ==27516==The signal is caused by a WRITE memory access.
    ==27516==Hint: address points to the zero page.
        #0 0x74564496a2f5 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:317:3
        #1 0x74564496a2f5 in RustMozCrash /mozglue/static/rust/wrappers.cpp:18:3
        #2 0x7456449697ad in mozglue_static::panic_hook::h43f486fae4fa321d /mozglue/static/rust/lib.rs:98:9
        #3 0x7456449697ad in core::ops::function::Fn::call::h5492db3e4b89e7be /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/ops/function.rs:79:5
        #4 0x745645a575a5 in _$LT$alloc..boxed..Box$LT$F$C$A$GT$$u20$as$u20$core..ops..function..Fn$LT$Args$GT$$GT$::call::hce488f674cf5618d /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/alloc/src/boxed.rs:2029:9
        #5 0x745645a575a5 in std::panicking::rust_panic_with_hook::hed79743dc8b4b969 /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:785:13
        #6 0x745645a572b8 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::ha437b5d58f431abf /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:651:13
        #7 0x745645a547e5 in std::sys_common::backtrace::__rust_end_short_backtrace::hd98e82d5b39ec859 /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/sys_common/backtrace.rs:171:18
        #8 0x745645a57043 in rust_begin_unwind /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:647:5
        #9 0x745645aa3254 in core::panicking::panic_fmt::hc69c4d258fe11477 /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/panicking.rs:72:14
        #10 0x745643ae9529 in wgpu_core::track::buffer::BufferTracker$LT$A$GT$::insert_single::h242ea20e2fde84e7 /third_party/rust/wgpu-core/src/track/buffer.rs:402:17
        #11 0x745643ae9529 in wgpu_core::device::global::_$LT$impl$u20$wgpu_core..global..Global$GT$::device_create_buffer::hef4bc8057b2a36e0 /third_party/rust/wgpu-core/src/device/global.rs:263:13
        #12 0x745643ae9529 in wgpu_server_device_create_buffer /gfx/wgpu_bindings/src/server.rs:483:9
        #13 0x74563ddcdc49 in mozilla::webgpu::WebGPUParent::RecvDeviceCreateBuffer(unsigned long, unsigned long, mozilla::dom::GPUBufferDescriptor&&, mozilla::ipc::UnsafeSharedMemoryHandle&&) /dom/webgpu/ipc/WebGPUParent.cpp:476:3
        #14 0x74563dde12fd in mozilla::webgpu::PWebGPUParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PWebGPUParent.cpp:764:80
        #15 0x74563be573bd in mozilla::gfx::PCanvasManagerParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PCanvasManagerParent.cpp:290:32
        #16 0x74563b3879bf in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1818:25
        #17 0x74563b384712 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message>>) /ipc/glue/MessageChannel.cpp:1737:9
        #18 0x74563b385392 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1530:3
        #19 0x74563b3864df in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1628:14
        #20 0x74563a67f411 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1193:16
        #21 0x74563a6863ed in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:480:10
        #22 0x74563b38ebce in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:300:20
        #23 0x74563b2a3861 in RunHandler /ipc/chromium/src/base/message_loop.cc:363:3
        #24 0x74563b2a3861 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:345:3
        #25 0x74563a67a6e3 in nsThread::ThreadFunc(void*) /xpcom/threads/nsThread.cpp:370:10
        #26 0x74564ecfd66f in _pt_root /nsprpub/pr/src/pthreads/ptthread.c:201:5
        #27 0x74564f59fac2 in start_thread nptl/pthread_create.c:442:8
        #28 0x74564f63184f  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:317:3 in MOZ_Crash
    ==27516==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20240411213648-036ac9a41b52.
The bug appears to have been introduced in the following build range:

Start: 149f61eecb69d6cf570be79260785c5b4a42e516 (20240227190003)
End: 612e5052e6e1b87c661886c015e3888c21730558 (20240227202530)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=149f61eecb69d6cf570be79260785c5b4a42e516&tochange=612e5052e6e1b87c661886c015e3888c21730558

Comment 3

[Mayank Bansal]

Got a crash from the testcase: https://crash-stats.mozilla.org/report/index/d2e94209-4bd2-4543-98a2-299830240412

Comment 4

[Teodor Tanasoaia [:teoxoy]]

Should be fixed by https://github.com/gfx-rs/wgpu/pull/5543. I'll block this on the next re-vendor once it lands.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 6

[Teodor Tanasoaia [:teoxoy]]

Fixed by 1891754.

Comment 7

[Bugmon [:jkratzer for issues]]

Verified bug as fixed on rev mozilla-central 20240419152244-7bb994599bd6.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.