1891141 - Make the page size for doing an Sqlite backup something that can be controlled via a pref / experiment

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1869060, I added support for cloning SQLite databases using the Online Backup API. Part of that involves copying certain pages of the database, then resting to yield to other requests, and then continuing the copy.

I used the same page value as was in the example, which was 5. That's defined statically here.

That value lets us trade between speed of the copy, and an amount of time we'd (presumably) block requests on the underlying database.

We should make it possible to tune this value.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Since the backup service is the only consumer of the SQLite backup method, is it okay for this page value to be a general preference accessed via StaticPrefs? Or would you prefer it be an optional argument that can be passed to backup?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1891141 - Add configuration parameters for pages per step and step delay to mozIStorageAsyncConnection.backupToFileAsync. r?mak!

This also fixes a bug in the test_connection_online_backup.js test which wasn't
properly evaluating that the page_size PRAGMA was being copied properly.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

Since the backup service is the only consumer of the SQLite backup method, is it okay for this page value to be a general preference accessed via StaticPrefs? Or would you prefer it be an optional argument that can be passed to backup?

I don't mind that much, I think an argument sounds fine.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1891141 - Create preferences for the pages per step and step delay used by BackupResources. r?#backup-reviewers!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

ni?ing mak for https://phabricator.services.mozilla.com/D207471#7124992.

Comment 6

[Marco Bonardo [:mak]]

replied there. Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccc7525869ae
Add configuration parameters for pages per step and step delay to mozIStorageAsyncConnection.backupToFileAsync. r=mak
https://hg.mozilla.org/integration/autoland/rev/790edb29878a
Create preferences for the pages per step and step delay used by BackupResources. r=backup-reviewers,fchasen

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/ccc7525869ae
https://hg.mozilla.org/mozilla-central/rev/790edb29878a