1891287 - Remove dom.keyboardevent.dispatch_during_composition pref

Status: RESOLVED FIXED

(Core :: DOM: Events, task)

Description

[Gregory Pappas [:gregp]]

It's been enabled by default for about 5 years now (bug 1496288, bug 354358). Is this pref still useful?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Well, the pref can be used for investing editing web apps which do not work with IME. However, in these days, I don't see such bug reports. I guess that it's caused by web apps use major frameworks and they are aware of IME due to the mobile platform. So, I think that it's fine to delete it.

Comment 2

[Chris Piemonte]

Attachment: WIP: Bug 1891287 - Removed dom.keyboardevent.dispatch_during_composition pref

Comment 3

[Chris Piemonte]

Hello, I'm a new contributor, and I'd like to help on this bug. I removed the references to the dom.keyboardevent.dispatch_during_composition pref in two files, modules/libpref/init/StaticPrefList.yaml and dom/base/test/chrome/window_nsITextInputProcessor.xhtml.

In the test file I removed two test functions that appeared to be testing functionality of the pref, and a try block in another test function that was referencing it. If I made a mistake in what I deleted please let me know. Also let me know if I need to run any test, thanks.

Comment 4

[Gregory Pappas [:gregp]]

Answered in Phabricator.

(it is better to make the patch available for review and keep all discussion about the details of the patch in Phabricator rather than go back and forth on bugzilla)

Comment 5

[Stephanie Cunnane [:scunnane]]

Updating the assignee, as the previous contributor is no longer working on Fx. Jeffrey will be picking up where Chris left off.

Comment 6

[Jeffrey Houghton]

Attachment: Bug 1891287 - Remove dom.keyboardevent.dispatch_during_composition pref.r?masayuki

Comment 7

[Jeffrey Houghton]

Attachment: Bug 1891287 - Remove dom.keyboardevent.dispatch_during_composition pref.r?masayuki

Comment 8

[Jeffrey Houghton]

Attachment: Bug 1891287 - Remove dom.keyboardevent.dispatch_during_composition pref.r?masayuki Differential Revision: https://phabricator.services.mozilla.com/D272947

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b805859cefc6
https://hg.mozilla.org/integration/autoland/rev/1a781637df70
Remove dom.keyboardevent.dispatch_during_composition pref.r=masayuki

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1a781637df70