1891420 - Disable internal pings for the correct application ID

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

We disabled it for firefox.desktop.background.update, which is the "Firefox for Desktop Background Update Task".
We want to have it disabled for firefox.desktop.background.defaultagent, which is WDBA.

And while we're at it maybe we should add that abbrevation to probe-scraper, because this is highly confusing.

Comment 1

[Jan-Erik Rediger [:janerik]]

Or is it?
The query from the original bug used firefox_desktop_background_defaultagent.

We have Firefox for Desktop Background Update Task, which uses the app id firefox.desktop.background.update.
It's comment says:

As of this writing, the Firefox Background Updater is Windows-only.

Dictionary entry

We also have Firefox Desktop Default Agent Task, which uses the app id firefox.desktop.background.defaultagent.
Dictionary entry.

The abbrevation WDBA is not used in the probe-scraper entries at all.

nrishel called out:

Looks like this disables pings for the Background Updater, not WDBA?

Nick, can you clear this up?
Which is which?
For which did we want to disable builtin pings?

Comment 2

[Nick Rishel [:nrishel]]

WDBA (Windows Default Browser Agent) and Default Agent are the same, so we want to disable internal pings for firefox.desktop.background.defaultagent.

I'm not sure if we wanted to disable internal pings for the Background Updater though? Leaving ni for :nalexander.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Rishel [:nrishel] from comment #2)

WDBA (Windows Default Browser Agent) and Default Agent are the same, so we want to disable internal pings for firefox.desktop.background.defaultagent.

I'm not sure if we wanted to disable internal pings for the Background Updater though? Leaving ni for :nalexander.

We want to keep the internal pings for the background updater. Sorry to not catch the incorrect name when reviewing.

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: [mozilla/probe-scraper] Bug 1891420 - Add the abbrevation WDBA so we know what it is (#728)

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1891420 - Disable internal pings for Windows Default Browser Agent. r?nalexander!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3470b630145
Disable internal pings for Windows Default Browser Agent. r=nalexander

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e3470b630145

Comment 8

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1891420 - Disable internal pings for Windows Default Browser Agent. r?nalexander!

Original Revision: https://phabricator.services.mozilla.com/D207613

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No telemetry sent from the background updater
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: Little.
• Explanation of risk level: Disabling sending pings was flipped accidentally. This patch reverts that and instead correctly disables it for WDBA
• String changes made/needed: -
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7610a650753b