1891502 - "undefined: undefined" error in console when content script does not exist

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Rob Wu [:robwu]]

While looking into bug 1884298, I found that when a content script does not exist, that undefined: undefined is printed at https://searchfox.org/mozilla-central/rev/d23849dd6d83edbe681d3b4828700256ea34a654/toolkit/components/extensions/ExtensionContent.sys.mjs#626.

This happens because the error is unexpectedly a string instead of an object.

Comment 1

[Rob Wu [:robwu]]

Although the issue could be solved (along with bug 1824896) by making sure that an error object is emitted from https://searchfox.org/mozilla-central/rev/d23849dd6d83edbe681d3b4828700256ea34a654/js/xpconnect/loader/ChromeScriptLoader.cpp#453,460, I'm going to fix this bug specifically by replacing the manual ${error.name}: ${error.message} serialization with error.toString(), since that would also address other cases where a string is encountered instead of an object.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1891502 - Log meaningful message instead of undefined:undefined

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e8c4adc46e1
Log meaningful message instead of undefined:undefined r=willdurand

Comment 4

[Aron Cseh [:acseh]]

https://hg.mozilla.org/mozilla-central/rev/7e8c4adc46e1