1891522 - Crash in [@ java.lang.RuntimeException: at com.android.org.kxml2.io.KXmlParser.adjustNsp(KXmlParser.java)] "Undefined Prefix: xlink"

Status: RESOLVED FIXED

(Fenix :: Tabs, defect)

Description

[Chris Peterson [:cpeterson]]

@ jackyzy: This crash looks like a regression in Fx 125. Could this crash be a regression from replacing coil-svg with AndroidSVG in bug 1879116?

Crash report: https://crash-stats.mozilla.org/report/index/b5a55a57-9858-4746-92a0-27ebf0240415

Message: Undefined Prefix: xlink in com.android.org.kxml2.io.KXmlParser@7f582a2

Top 10 frames:

0  com.android.org.kxml2.io.KXmlParser  adjustNsp  KXmlParser.java:262
1  com.android.org.kxml2.io.KXmlParser  parseStartTag  KXmlParser.java:1167
2  com.android.org.kxml2.io.KXmlParser  next  KXmlParser.java:380
3  com.android.org.kxml2.io.KXmlParser  nextToken  KXmlParser.java:325
4  com.caverock.androidsvg.SVGParser  parseUsingXmlPullParser  SVGParser.java:244
5  com.caverock.androidsvg.SVGParser  parse  SVGParser.java:56
6  mozilla.components.browser.icons.decoder.SvgIconDecoder  decode  SvgIconDecoder.kt:24
7  mozilla.components.browser.icons.BrowserIconsKt  decodeIconLoaderResult  BrowserIcons.kt:51
8  mozilla.components.browser.icons.BrowserIcons$backgroundHttpIconLoader$1  invoke  BrowserIcons.kt:58
9  mozilla.components.browser.icons.loader.NonBlockingHttpIconLoader$load$1  invokeSuspend  NonBlockingHttpIconLoader.kt:18

Comment 1

[jackyzy823]

Yes. so I made a patch in bug 1888374 trying to catch the most generic exception to make decoder robust.

If the situation is severe, maybe we could uplift it?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yeah, we can definitely keep that on the radar for a dot release uplift. Looks like these crashes weren't really happening on Nightly, so let's see what Beta 126 does with that fix and we can go from there.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

No crashes from Beta 126. Calling this fixed by bug 1888374.