1891577 - Bookmarked web site favicon not loading because of Enhanced Tracking Protection.

Status: NEW

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

Go to benefit.identityforce.com.

Bookmark this page.

Actual results:

Bookmark displays the Fx default globe icon.

Expected results:

The sites favicon should appear on the bookmarked site.

MS Edge correctly displays the sites Favicon on it's bookmark. Inquiries from other FX users seems to suggest this is happening, or not happening, on all the channels.

Comment 1

[Gary [:streetwolf52]]

Tried in safe mode and with a new profile. The bookmarked site's icon is always the globe.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Gary [:streetwolf52]]

See user comments on this issue at https://forums.mozillazine.org/viewtopic.php?t=3120765

Comment 4

[Marco Bonardo [:mak]]

For some reason this site is adding favicons dinamically after the pageshow event:

<script type='text/javascript'>(function() {
      var link = document.querySelector("link[rel*='icon']") || document.createElement('link');
      link.type = 'image/x-icon';
      link.rel = 'shortcut icon';
      link.href = 'https://secure.identityforce.com/funnel/sales/img/idf-icon-logo.png';
      document.getElementsByTagName('head')[0].appendChild(link);
 })();

This method is normally used by sites to show indicator/status favicons, thus we don't store them as it doesn't make sense to store temporary status icons. We don't plan to change that, so that's pretty much a Web Compat problem.

In this case the root icon (https://benefit.identityforce.com/favicon.ico) should be loaded.
Instead I see NS_BINDING_ABORTED in the devtools.
If I disable Enhanced Tracking Protection the icon is loaded properly.

FaviconLoader.sys.mjs should probably be able to bypass ETP.
Tim, is there any way to do that, or do you have any suggestions about this case?

Comment 5

[Tim Huang[:timhuang]]

We can set the mIsOnContentAllowList value of the CookieJarSettings of the loading channel to bypass ETP for the loading request from FaviconLoader. However, this value now can only be modified from the C++ code, we don't have a idl function to set this value. So, I think we need to add an IDL function on nsICookieJarSettings.idl for setting the value. And change it before loading the channel so that we can bypass ETP for the request.

Comment 6

[Marco Bonardo [:mak]]

Thank you!
Since this needs platform changes, I'm moving the bug to the privacy component.
The FaviconLoader change will likely be trivial at that point and can be done there.

Comment 7

[Gary [:streetwolf52]]

As mentioned, turning of Enhanced Tracking resulted in the sites favicon appearing on my bookmark for the site. I just realized that Enhance Tracking was turned back on at some point and the favicon on my bookmark still remains. So it appears ET only needs to be turned off once to get the favicon and then it can be turned back on although it looks like Fx turned it back on because I didn't.

Comment 8

[mlucks]

Attachment: WIP: Bug 1891577 - Set favicons to bypass ETP - r?timhuang,kpatenio