18916 - Group digits for disk space/file space sizes

Status: VERIFIED WORKSFORME

(SeaMonkey :: Installer, enhancement, P5)

Description

[Eli Goldberg]

* TITLE/SUMMARY
Please add commas to disk space/file space sizes

* STEPS TO REPRODUCE
0) Launch Mozilla Installer (11.15.99)
1) Pursuant to your platform...
	Mac OS: Navigate to the page with the Typical/Custom pop-up menu.
 Win32: Select a Custom installation, and click "Next"

* RESULT
 - What happened

The listed hard drive space is in a comma-less format, e.g. "1422276 K".

 - What was expected

In a world where 20 Gig hard drives are standard equipment on new computers and
users can have 15343284 K free, it would be clearer to include commas (e.g.
15,343,284 K free) when displaying the numbers.

* REGRESSION

 - Occurs On
        Mac OS Mozilla Installer (11.15.99)
        Win32 Mozilla Installer (11.13.99-ish M11 candidate)

 - Doesn't Occur On
        Mac OS VISE Installer (from Communicator 4.7)

* CONFIGURATIONS TESTED

- [Mac] Beige Power Mac G3 (266 MHz PowerPC 750), 96 MB RAM (VM on; 1 MB of VM
used), 1024x768 (Thousands of Colors), Mac OS 8.6

- [Win32] Vectra VL (233 MHz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP5.

- [Linux] Vectra VL (266 MHz P2), 96 MB RAM. Red Hat Linux 6.0 (GNOME).

Comment 1

[Sean Su]

setting target milestone to m15

Comment 2

[Ben Bucksch (:BenB)]

Changing topic from "Please add commas to disk space/file space sizes" to "Group
digits for disk space/file space sizes" for I18N (In German, the meaning of ","
and "." is swapped in comparision to English). Follow OS setting.

Comment 3

[Sean Su]

moving to M20

Comment 4

[Sean Su]

*** Bug 38471 has been marked as a duplicate of this bug. ***

Comment 5

[timeless]

where is installer in the tree?
LordPixel could you help w/ the mac version of this?

windows:
#include <winnls.h>
int GetNumberFormat(
    LCID Locale,	// locale for which number string is to be formatted 
    DWORD dwFlags,	// bit flag that controls the function's operation
    LPCTSTR lpValue,	// pointer to input number string
    CONST NUMBERFMT *lpFormat,	// pointer to a formatting information 
structure
    LPTSTR lpNumberStr,	// pointer to output buffer 
    int cchNumber 	// size of output buffer
   );

LCID should be one of:
LOCALE_SYSTEM_DEFAULT	//Default system locale.
LOCALE_USER_DEFAULT	//Default user locale.

dwFlags should be LOCALE_NOUSEROVERRIDE [i think]
lpFormat should be NULL //the function uses the number format of the specified 
locale.

lpValue

Points to a null-terminated string containing the number string to format. 
This string can only contain the following characters:

·	Characters '0' through '9'
·	One decimal point (dot) if the number is a floating-point value
·	A minus sign in the first character position if the number is a 
negative value

All other characters are invalid. The function returns an error if the string 
pointed to by lpValue deviates from these rules.

lpNumberStr

Points to a buffer to receive the formatted number string.

cchNumber

Specifies the size, in bytes (ANSI version) or characters (Unicode version), of 
the lpNumberStr buffer. If cchNumber is zero, the function returns the number 
of bytes or characters required to hold the formatted number string, and the 
buffer pointed to by lpNumberStr is not used.

Return Values

If the function succeeds, the return value is the number of bytes (ANSI 
version) or characters (Unicode version) written to the buffer pointed to by 
lpNumberStr, or if the cchNumber parameter is zero, the number of bytes or 
characters required to hold the formatted number string. 
If the function fails, the return value is zero.

Comment 6

[Daniel Veditz [:dveditz]]

Changing obsolete M20+ milestones to closest equivalent, "Future"

Comment 7

[Sean Su]

over to Curt.

Comment 8

[Andrew Schultz]

windows-only
on linux, space is only shown when it is insufficient (<30MB), so proper display
of 2482839 KB is not a problem.

Comment 9

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer

Comment 10

[Ben Bucksch (:BenB)]

> if you still get this with the new installer

... then file a bug against NSIS :).

VERIFIED OUTDATED