Open Bug 1891618 Opened 2 months ago Updated 2 months ago

Directory Lookup Changes for Versioned Installs

Categories

(Toolkit :: Application Update, task, P3)

Product:
Toolkit
Component:
Application Update
Type:
task

Tracking

()

People

(Reporter: bytesized, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fidedi-ope])

When using versioned installation directories, the installation directory and the GRE directory (the directory containing the binaries) will no longer be the same directory on Windows. We will need to make sure that relevant entries in the directory service will get the correct directories after this change.

This should not introduce many issues since we already support having different installation and GRE directories as this is the current situation on macOS. However, it is possible that there is non-macOS code that is less careful about this distinction. It would be prudent to audit the current lookups of the installation/GRE directory (using the directory service or otherwise) and make sure that they will still be looking up what they meant to after the versioned installation directory switch.

Most of the aforementioned directory lookups want the GRE directory but, occasionally, we want to do something like computing the hash of the installation directory (which should not change when the version changes). In cases like this, we want to make sure that we look up the root of the installation directory, not the GRE directory.

All of this behavior should be behind the Versioned Installation Directory Build Flag (Bug 1891616).

This bug tracks changes to Firefox only, not the update binary.

(In reply to Robin Steuber (they/them) [:bytesized] from comment #0)

This bug tracks changes to Firefox only, not the update binary.

One note on this: one of the current arguments to the update binary is the install/gre directory. Going forward, we want this to be the GRE directory, not the installation directory. The updater can trivially find the update directory from the GRE directory, and it needs to know what versioned installation to update from in order to apply the update patch.

Oops, sorry. The above is incorrect. We want to pass the install directory, not the gre directory here. We will know what version we are updating via the work in Bug 1892061. We don't want to rely on the launching version being the version from which the update should be applied, because it may not be the same as the downloading version.

You need to log in before you can comment on or make changes to this bug.